New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Cisco UCM category from tele to telephony #6297

Merged
merged 4 commits into from Apr 12, 2017

Conversation

Projects
None yet
7 participants
@aldemira
Contributor

aldemira commented Mar 29, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

I think tele doesn't mean much.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Mar 29, 2017

Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 29, 2017

Member

Thanks for this, to change a type you will need to also submit a notification that this is changing: librenms/librenms.github.io#83

However it will also need more work doing, tele at the moment must be broke but it also needs at least something in includes/definitions.inc.php:

$config['device_types'][$i]['text'] = 'Printers';
$config['device_types'][$i]['type'] = 'printer';
$config['device_types'][$i]['icon'] = 'printer.png';

As an example.

Member

laf commented Mar 29, 2017

Thanks for this, to change a type you will need to also submit a notification that this is changing: librenms/librenms.github.io#83

However it will also need more work doing, tele at the moment must be broke but it also needs at least something in includes/definitions.inc.php:

$config['device_types'][$i]['text'] = 'Printers';
$config['device_types'][$i]['type'] = 'printer';
$config['device_types'][$i]['icon'] = 'printer.png';

As an example.

@laf laf added the Blocker 🚫 label Mar 29, 2017

Your Name
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Mar 30, 2017

Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 31, 2017

Member

Thanks @aldemira. This just needs the notification now adding, let us know when that's been done.

Member

laf commented Mar 31, 2017

Thanks @aldemira. This just needs the notification now adding, let us know when that's been done.

@aldemira

This comment has been minimized.

Show comment
Hide comment
@aldemira

aldemira Apr 3, 2017

Contributor

I'm sorry I couldn't get what you mean by notifications?

Contributor

aldemira commented Apr 3, 2017

I'm sorry I couldn't get what you mean by notifications?

@adaniels21487

This comment has been minimized.

Show comment
Hide comment
@adaniels21487

adaniels21487 Apr 5, 2017

Contributor

I would prefer this changed to 'collaboration' to be consistent with: Acano, Expressway, VC Endpoints and TPS.

Contributor

adaniels21487 commented Apr 5, 2017

I would prefer this changed to 'collaboration' to be consistent with: Acano, Expressway, VC Endpoints and TPS.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 5, 2017

Member

@aldemira What do you think?

@adaniels21487 If we do stick with that then it needs a group definition like this PR has, that looks to be missed when collaboration was added.

Member

laf commented Apr 5, 2017

@aldemira What do you think?

@adaniels21487 If we do stick with that then it needs a group definition like this PR has, that looks to be missed when collaboration was added.

@aldemira

This comment has been minimized.

Show comment
Hide comment
@aldemira

aldemira Apr 5, 2017

Contributor

I'm fine with that as long as it's not "Tele". So shall I update the code then?

Contributor

aldemira commented Apr 5, 2017

I'm fine with that as long as it's not "Tele". So shall I update the code then?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 5, 2017

Member

@aldemira Yes please, I'll do the notification once you have.

Member

laf commented Apr 5, 2017

@aldemira Yes please, I'll do the notification once you have.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 6, 2017

Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org

@f0o

f0o approved these changes Apr 6, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Apr 6, 2017

Member

Ok, the notification has gone out. Will merge Monday 10th.

Member

laf commented Apr 6, 2017

Ok, the notification has gone out. Will merge Monday 10th.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Apr 6, 2017

Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 6, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Apr 6, 2017

The inspection completed: No new issues

@murrant murrant merged commit cea6169 into librenms:master Apr 12, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment