New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Cisco UCM category from tele to telephony #6297
Conversation
Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org |
Thanks for this, to change a type you will need to also submit a notification that this is changing: librenms/librenms.github.io#83 However it will also need more work doing, tele at the moment must be broke but it also needs at least something in includes/definitions.inc.php:
As an example. |
Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org |
Thanks @aldemira. This just needs the notification now adding, let us know when that's been done. |
I'm sorry I couldn't get what you mean by notifications? |
I would prefer this changed to 'collaboration' to be consistent with: Acano, Expressway, VC Endpoints and TPS. |
@aldemira What do you think? @adaniels21487 If we do stick with that then it needs a group definition like this PR has, that looks to be missed when collaboration was added. |
I'm fine with that as long as it's not "Tele". So shall I update the code then? |
@aldemira Yes please, I'll do the notification once you have. |
Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org |
Ok, the notification has gone out. Will merge Monday 10th. |
Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org |
The inspection completed: No new issues |
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
I think tele doesn't mean much.