Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Cisco UCM category from tele to telephony #6297

Merged
merged 4 commits into from Apr 12, 2017
Merged

Change Cisco UCM category from tele to telephony #6297

merged 4 commits into from Apr 12, 2017

Conversation

aldemira
Copy link
Contributor

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

I think tele doesn't mean much.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org

@laf
Copy link
Member

laf commented Mar 29, 2017

Thanks for this, to change a type you will need to also submit a notification that this is changing: librenms/librenms.github.io#83

However it will also need more work doing, tele at the moment must be broke but it also needs at least something in includes/definitions.inc.php:

$config['device_types'][$i]['text'] = 'Printers';
$config['device_types'][$i]['type'] = 'printer';
$config['device_types'][$i]['icon'] = 'printer.png';

As an example.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org

@laf
Copy link
Member

laf commented Mar 31, 2017

Thanks @aldemira. This just needs the notification now adding, let us know when that's been done.

@aldemira
Copy link
Contributor Author

aldemira commented Apr 3, 2017

I'm sorry I couldn't get what you mean by notifications?

@adaniels21487
Copy link
Contributor

I would prefer this changed to 'collaboration' to be consistent with: Acano, Expressway, VC Endpoints and TPS.

@laf
Copy link
Member

laf commented Apr 5, 2017

@aldemira What do you think?

@adaniels21487 If we do stick with that then it needs a group definition like this PR has, that looks to be missed when collaboration was added.

@aldemira
Copy link
Contributor Author

aldemira commented Apr 5, 2017

I'm fine with that as long as it's not "Tele". So shall I update the code then?

@laf
Copy link
Member

laf commented Apr 5, 2017

@aldemira Yes please, I'll do the notification once you have.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org

@laf
Copy link
Member

laf commented Apr 6, 2017

Ok, the notification has gone out. Will merge Monday 10th.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6297.ci.librenms.org or https://6297.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@murrant murrant merged commit cea6169 into librenms:master Apr 12, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants