New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Added additional sensors support for HP ILO4 #7053

Merged
merged 4 commits into from Jul 19, 2017

Conversation

Projects
None yet
6 participants
@laf
Member

laf commented Jul 18, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Replaces: #6996

TomEvin and others added some commits Jul 10, 2017

device: Improved HP ILO4 support
Added HP ILO4 temperature (HDD, motherboard), power, state (powersupply, HDD, Fans, memory slots) sensors support.
Tested with HP ProLiant ML350p Gen8-Gen9
@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Jul 18, 2017

Member

is this ok to test pull on?

Member

kkrumm1 commented Jul 18, 2017

is this ok to test pull on?

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 18, 2017

Auto-Deploy finished, Test PR at http://7053.ci.librenms.org or https://7053.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 18, 2017

Member

@kkrumm1 it is now.

Member

laf commented Jul 18, 2017

@kkrumm1 it is now.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 18, 2017

Auto-Deploy finished, Test PR at http://7053.ci.librenms.org or https://7053.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 18, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 18, 2017

The inspection completed: No new issues

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Jul 18, 2017

Member

Receiving this error when I git pull "error: mibs/CPQHLTH-MIB: No such file or directory"

Member

kkrumm1 commented Jul 18, 2017

Receiving this error when I git pull "error: mibs/CPQHLTH-MIB: No such file or directory"

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 18, 2017

Member

That's been moved, have you checked my branch out?

Member

laf commented Jul 18, 2017

That's been moved, have you checked my branch out?

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Jul 18, 2017

Member

i don't think so all did was ./scripts/github-apply 7053

Member

kkrumm1 commented Jul 18, 2017

i don't think so all did was ./scripts/github-apply 7053

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 18, 2017

Member

That might not work well with files being moved around :/

Member

laf commented Jul 18, 2017

That might not work well with files being moved around :/

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 18, 2017

Member

Oh, but you don't need to git pull when you've run the apply script, the script is all you need

Member

laf commented Jul 18, 2017

Oh, but you don't need to git pull when you've run the apply script, the script is all you need

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Jul 18, 2017

Member
Member

kkrumm1 commented Jul 18, 2017

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Jul 18, 2017

Member

@laf Here is what I'm seeing https://pastebin.com/qsWkTzQF

Member

kkrumm1 commented Jul 18, 2017

@laf Here is what I'm seeing https://pastebin.com/qsWkTzQF

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 18, 2017

Member

That doesn't seem to show the end. Sometimes the apply script isn't the best to cover things where files are moved around so if you want to test properly I suggest checking out my branch.

Member

laf commented Jul 18, 2017

That doesn't seem to show the end. Sometimes the apply script isn't the best to cover things where files are moved around so if you want to test properly I suggest checking out my branch.

@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Jul 18, 2017

Member
Member

kkrumm1 commented Jul 18, 2017

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Jul 19, 2017

Contributor

Do you want that I migrate the code to the new YAML format?

[EDIT] PR mix, it's already done! Wonderful. [/EDIT]

Contributor

FTBZ commented Jul 19, 2017

Do you want that I migrate the code to the new YAML format?

[EDIT] PR mix, it's already done! Wonderful. [/EDIT]

@laf laf merged commit da7550f into librenms:master Jul 19, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.