Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Added additional sensors support for HP ILO4 #7053

Merged
merged 4 commits into from Jul 19, 2017

Conversation

laf
Copy link
Member

@laf laf commented Jul 18, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Replaces: #6996

TomEvin and others added 2 commits July 11, 2017 16:19
Added HP ILO4 temperature (HDD, motherboard), power, state (powersupply, HDD, Fans, memory slots) sensors support.
Tested with HP ProLiant ML350p Gen8-Gen9
@laf laf added the Device 🖥️ New or added device support label Jul 18, 2017
@kkrumm1
Copy link
Member

kkrumm1 commented Jul 18, 2017

is this ok to test pull on?

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://7053.ci.librenms.org or https://7053.ci.librenms.org

@laf
Copy link
Member Author

laf commented Jul 18, 2017

@kkrumm1 it is now.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://7053.ci.librenms.org or https://7053.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@kkrumm1
Copy link
Member

kkrumm1 commented Jul 18, 2017

Receiving this error when I git pull "error: mibs/CPQHLTH-MIB: No such file or directory"

@laf
Copy link
Member Author

laf commented Jul 18, 2017

That's been moved, have you checked my branch out?

@kkrumm1
Copy link
Member

kkrumm1 commented Jul 18, 2017

i don't think so all did was ./scripts/github-apply 7053

@laf
Copy link
Member Author

laf commented Jul 18, 2017

That might not work well with files being moved around :/

@laf
Copy link
Member Author

laf commented Jul 18, 2017

Oh, but you don't need to git pull when you've run the apply script, the script is all you need

@kkrumm1
Copy link
Member

kkrumm1 commented Jul 18, 2017 via email

@kkrumm1
Copy link
Member

kkrumm1 commented Jul 18, 2017

@laf Here is what I'm seeing https://pastebin.com/qsWkTzQF

@laf
Copy link
Member Author

laf commented Jul 18, 2017

That doesn't seem to show the end. Sometimes the apply script isn't the best to cover things where files are moved around so if you want to test properly I suggest checking out my branch.

@kkrumm1
Copy link
Member

kkrumm1 commented Jul 18, 2017 via email

@ghost
Copy link

ghost commented Jul 19, 2017

Do you want that I migrate the code to the new YAML format?

[EDIT] PR mix, it's already done! Wonderful. [/EDIT]

@laf laf merged commit da7550f into librenms:master Jul 19, 2017
@lock
Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants