multiple fixes under agentStpSwitchConfigGroup in EdgeSwitch-SWITCHING-MIB #7180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…G-MIB Specifically: agentStpPortTable should be at agentStpSwitchConfigGroup.9, not .7 agentStpCstConfigGroup should be at .10, not .8 agentStpCstPortTable should be at .11, not .9 agentStpMstTable should be at .12, not .10 agentStpMstPortTable should be at .13, not .11 agentStpMstVlanTable should be at .14, not .12 agentStpBpduGuardMode should be at .7, not .13 agentStpBpduFilterDefault should be at .8, not .14 ...and agentStpPortHelloTime should exist at agentStpPortEntry.10
|
|
|
The inspection completed: No new issues |
|
So you've stopped by to submit a fix to the mib rather than being a LibreNMS user? If so, wow, thanks :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to find anywhere to submit these changes upstream, so I'm just
submitting them to you so that you can have them (since you were nice enough
to have the MIB for me to start with).
Corrections here have been verified both in the firmware (which, if you peel
it apart, contains both the OIDs and associated names), and by pulling the
associated data from switches and comparing the results to the expected
results gleaned from the switch's human-targeted interfaces.
Specific corrections:
agentStpPortTable should be at agentStpSwitchConfigGroup.9, not .7
agentStpCstConfigGroup should be at .10, not .8
agentStpCstPortTable should be at .11, not .9
agentStpMstTable should be at .12, not .10
agentStpMstPortTable should be at .13, not .11
agentStpMstVlanTable should be at .14, not .12
agentStpBpduGuardMode should be at .7, not .13
agentStpBpduFilterDefault should be at .8, not .14
...and agentStpPortHelloTime should exist at agentStpPortEntry.10
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926