New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple fixes under agentStpSwitchConfigGroup in EdgeSwitch-SWITCHING-MIB #7180

Merged
merged 1 commit into from Aug 18, 2017

Conversation

Projects
None yet
4 participants
@elfchief
Contributor

elfchief commented Aug 18, 2017

I was unable to find anywhere to submit these changes upstream, so I'm just
submitting them to you so that you can have them (since you were nice enough
to have the MIB for me to start with).

Corrections here have been verified both in the firmware (which, if you peel
it apart, contains both the OIDs and associated names), and by pulling the
associated data from switches and comparing the results to the expected
results gleaned from the switch's human-targeted interfaces.

Specific corrections:
agentStpPortTable should be at agentStpSwitchConfigGroup.9, not .7
agentStpCstConfigGroup should be at .10, not .8
agentStpCstPortTable should be at .11, not .9
agentStpMstTable should be at .12, not .10
agentStpMstPortTable should be at .13, not .11
agentStpMstVlanTable should be at .14, not .12
agentStpBpduGuardMode should be at .7, not .13
agentStpBpduFilterDefault should be at .8, not .14

...and agentStpPortHelloTime should exist at agentStpPortEntry.10

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

multiple fixes under agentStpSwitchConfigGroup in EdgeSwitch-SWITCHIN…
…G-MIB

Specifically:
  agentStpPortTable should be at agentStpSwitchConfigGroup.9, not .7
  agentStpCstConfigGroup should be at .10, not .8
  agentStpCstPortTable should be at .11, not .9
  agentStpMstTable should be at .12, not .10
  agentStpMstPortTable should be at .13, not .11
  agentStpMstVlanTable should be at .14, not .12
  agentStpBpduGuardMode should be at .7, not .13
  agentStpBpduFilterDefault should be at .8, not .14

  ...and agentStpPortHelloTime should exist at agentStpPortEntry.10
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 18, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 18, 2017

CLA assistant check
All committers have signed the CLA.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 18, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 18, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 18, 2017

Member

So you've stopped by to submit a fix to the mib rather than being a LibreNMS user? If so, wow, thanks :)

Member

laf commented Aug 18, 2017

So you've stopped by to submit a fix to the mib rather than being a LibreNMS user? If so, wow, thanks :)

@laf laf merged commit 3ed5aca into librenms:master Aug 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

neg2led added a commit to neg2led/librenms that referenced this pull request Aug 21, 2017

multiple fixes under agentStpSwitchConfigGroup in EdgeSwitch-SWITCHIN…
…G-MIB (#7180)

Specifically:
  agentStpPortTable should be at agentStpSwitchConfigGroup.9, not .7
  agentStpCstConfigGroup should be at .10, not .8
  agentStpCstPortTable should be at .11, not .9
  agentStpMstTable should be at .12, not .10
  agentStpMstPortTable should be at .13, not .11
  agentStpMstVlanTable should be at .14, not .12
  agentStpBpduGuardMode should be at .7, not .13
  agentStpBpduFilterDefault should be at .8, not .14

  ...and agentStpPortHelloTime should exist at agentStpPortEntry.10
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.