refactor: rewrite is_valid_port()

[murrant]

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

• Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Take two. Fixed the error and added tests.
fix: return $default; -> return self::get($key, $default);

---

This change is 

[scrutinizer-notifier]

The inspection completed: 3 new issues, 5 updated code elements

[laf]

Tested fine for me.

Is it worth adding something like: https://p.libren.ms/view/raw/b62397e4 (tests/PortsTest.php)

[murrant]

TLDR: yes

Higher level tests are almost universally better. They test more and the right things. Also allow for refactoring without re-writing tests.

We can't go all the way to the top level with librenms tests right now, so, we build up from the bottom. The OS discovery tests are about right. They take input from the outside (snmp) and produce output to the user (os type).

The best way to test this code would be to add some snmprec that has ports. Then set some config variables and verify that the correct ports are ignored. That is kinda difficult, but the closer we get to that the more useful our tests are.

[network-guy]

LGTM

[laf]

So adding it in or not for now @murrant as the PR itself is good to go.

[murrant]

@laf This is good to merge for me. We can wait to add the higher level tests I talked about separately.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed.