Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrdcached needs -R to work properly #7393

Merged
merged 2 commits into from Sep 27, 2017
Merged

rrdcached needs -R to work properly #7393

merged 2 commits into from Sep 27, 2017

Conversation

jackson-tim
Copy link
Contributor

@jackson-tim jackson-tim commented Sep 27, 2017

Without -R you'll hate yourself.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This change is Reviewable

Without -R you'll hate yourself.
@@ -108,7 +108,7 @@ Running RRDCached
Ubuntu (/etc/default/rrdcached)
```conf
OPTS="-l 0:42217"
OPTS="$OPTS -j /var/lib/rrdcached/journal/ -F"
OPTS="$OPTS -R -j /var/lib/rrdcached/journal/ -F"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-R only works for 1.5.5 and above, can you duplicate the code block, remove -R from the old block and do:

Ubuntu (/etc/default/rrdcached) - RRDCached 1.5.5 and above.

OPTS="-l 0:42217"
OPTS="$OPTS -R -j /var/lib/rrdcached/journal/ -F"
OPTS="$OPTS -b /opt/librenms/rrd -B"
OPTS="$OPTS -w 1800 -z 900"

@laf
Copy link
Member

laf commented Sep 27, 2017

Just a small change due to the difference in versions.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@laf laf merged commit f24c840 into librenms:master Sep 27, 2017
@lock
Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants