Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cdp matching incorrect ports #7491

Merged
merged 1 commit into from Oct 15, 2017
Merged

Conversation

murrant
Copy link
Member

@murrant murrant commented Oct 15, 2017

Need either remote device_id or mac_address to find a port, otherwise, we might match an incorrect port.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Need either remote device_id or mac_address to find a port, otherwise, we might match an incorrect port.
@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues, 1 updated code elements

@laf laf merged commit 2f2234d into librenms:master Oct 15, 2017
@murrant murrant deleted the fix-find_port branch October 16, 2017 03:39
@lock
Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants