Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added temperature sensor to datacom switches. #7522

Merged
merged 3 commits into from Oct 21, 2017
Merged

Added temperature sensor to datacom switches. #7522

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76ca2a6
Update most recent Mib
Oct 20, 2017
c907b55
Added switch emeperature sensor.
Oct 20, 2017
3f39ae1
Revert manual limits.
Oct 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions includes/definitions/discovery/datacom.yaml
View file
Open in desktop
@@ -0,0 +1,13 @@
mib: DMswitch-MIB
modules:
sensors:
temperature:
data:
-
oid: SwitchInfoEntry
value: swTemperature
num_oid: .1.3.6.1.4.1.3709.3.5.201.1.1.2.1.12.
descr: 'Temperature {{ $index }}'
index: 'swTemperature.{{ $index }}'
low_limit: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come you are hard coding the low / high limits? Is it not worth leaving it to be autocalculated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are values supplied by the manufacturer. Where can i check how values are autocalculated ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supplied in the docs but not via snmp? If it's not from snmp then leave it as is. The auto calc is done on the current value so can vary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, no info on mibs.

high_limit: 55
42 changes: 41 additions & 1 deletion mibs/datacom/DMswitch-MIB
View file
Open in desktop
Expand Up @@ -779,7 +779,7 @@ swChassisModel OBJECT-TYPE
::= { switchMgt 17 }

switchSessionTable OBJECT-TYPE
SYNTAX SEQUENCE OF SwitchSessionEntry
SYNTAX SEQUENCE OF SwitchIndivAlarmOutEntry
MAX-ACCESS not-accessible
STATUS current
DESCRIPTION "Table about CLI sessions informations."
Expand Down Expand Up @@ -4820,4 +4820,44 @@ ddTransceiversTxBias OBJECT-TYPE
DESCRIPTION "Transceiver tx bias information in Amperes"
::= { ddTransceiversEntry 6 }

ddTransceiversTemperatureValue OBJECT-TYPE
SYNTAX Integer32
UNITS "Celsius (degrees C)"
MAX-ACCESS read-only
STATUS current
DESCRIPTION "Transceiver temperature infomation"
::= { ddTransceiversEntry 7 }

ddTransceiversVcc3v3Value OBJECT-TYPE
SYNTAX Integer32
UNITS "0.1 V"
MAX-ACCESS read-only
STATUS current
DESCRIPTION "Transceiver Vcc 3v3 infomation"
::= { ddTransceiversEntry 8 }

ddTransceiversRxPowerValue OBJECT-TYPE
SYNTAX Integer32
UNITS "0.1 dBm"
MAX-ACCESS read-only
STATUS current
DESCRIPTION "Transceiver rx power infomation"
::= { ddTransceiversEntry 9 }

ddTransceiversTxPowerValue OBJECT-TYPE
SYNTAX Integer32
UNITS "0.1 dBm"
MAX-ACCESS read-only
STATUS current
DESCRIPTION "Transceiver tx power infomation"
::= { ddTransceiversEntry 10 }

ddTransceiversTxBiasValue OBJECT-TYPE
SYNTAX Integer32
UNITS "0.1 mA"
MAX-ACCESS read-only
STATUS current
DESCRIPTION "Transceiver tx bias infomation"
::= { ddTransceiversEntry 11 }

END