New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors with missing posix extension #7666

Merged
merged 2 commits into from Nov 10, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Nov 7, 2017

It should be an optional dependency

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: errors with missing posix extension
It should be an optional dependency
$suggested_extensions = array('posix' => 'php-process');
foreach ($suggested_extensions as $extension => $packages) {
if (!extension_loaded($extension)) {
$validator->warn("Missing optional PHP extension: $extension", "It is suggested you install $packages or the one that matches your php version");

This comment has been minimized.

@laf

laf Nov 7, 2017

Member

Will this not just lead to people asking about install this and should we not just have it as part of the install docs?

@laf

laf Nov 7, 2017

Member

Will this not just lead to people asking about install this and should we not just have it as part of the install docs?

This comment has been minimized.

@murrant

murrant Nov 9, 2017

Member

Yeah, probably would be worth adding it to the install docs. No change is necessary on Ubuntu.

@murrant

murrant Nov 9, 2017

Member

Yeah, probably would be worth adding it to the install docs. No change is necessary on Ubuntu.

This comment has been minimized.

@laf

laf Nov 9, 2017

Member

As in it's already installed?

@laf

laf Nov 9, 2017

Member

As in it's already installed?

This comment has been minimized.

@murrant

murrant Nov 10, 2017

Member

As in for Debian/Ubuntu, it is part of php core.

@murrant

murrant Nov 10, 2017

Member

As in for Debian/Ubuntu, it is part of php core.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Nov 10, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Nov 10, 2017

The inspection completed: 2 updated code elements

@laf laf merged commit b79d106 into librenms:master Nov 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-missing-posix branch Nov 10, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.