fix: errors with missing posix extension #7666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be an optional dependency
laf
reviewed
Nov 7, 2017
| $suggested_extensions = array('posix' => 'php-process'); | ||
| foreach ($suggested_extensions as $extension => $packages) { | ||
| if (!extension_loaded($extension)) { | ||
| $validator->warn("Missing optional PHP extension: $extension", "It is suggested you install $packages or the one that matches your php version"); |
There was a problem hiding this comment.
Will this not just lead to people asking about install this and should we not just have it as part of the install docs?
There was a problem hiding this comment.
Yeah, probably would be worth adding it to the install docs. No change is necessary on Ubuntu.
There was a problem hiding this comment.
As in for Debian/Ubuntu, it is part of php core.
|
The inspection completed: 2 updated code elements |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be an optional dependency
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926