refactor: Added the Nvidia SM average as app_status #7671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
murrant
reviewed
Nov 7, 2017
| $gpus=0; | ||
| $sm_total=0; | ||
| while (isset($gpuArray[$gpus])) { | ||
| $sm_total = $sm_total+explode(",", $gpuArray[$gpus])[3]; |
There was a problem hiding this comment.
You can do:
foreach ($gpuArray as $gpu) {
$stats = explode(",", $gpu);
$sm_total += $stats[3];
}
$sm_average = ($sm_total ? 0 : ($sm_total / count($gpuArray));
Can't reference an array like that in php 5.3 :-)
Need to avoid divide by zero too.
tim427
changed the title
Zmegolaz
suggested changes
Nov 8, 2017
| } | ||
| $sm_average = ($sm_total ? 0 : ($sm_total / count($gpuArray))); |
There was a problem hiding this comment.
This should probably be the other way around, if $sm_total evaluates to true, it should calculate the average.
|
The inspection completed: 1 new issues |
Zmegolaz
approved these changes
Nov 8, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926