Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hillstone StoneOs detection #7982

Merged
merged 15 commits into from Jan 8, 2018
Merged

Added Hillstone StoneOs detection #7982

merged 15 commits into from Jan 8, 2018

Conversation

alangregory
Copy link

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Copy link
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No svg logo to use?

If not, this logo needs to be square for the devices list. Should be 32x32 ideally.

text: Memory Usage
discovery:
-
sysObjectId: .1.3.6.1.4.1.28557.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need sysDescr as well? Will sysObjectID not be unique enough?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only Hillstone use this Oid, removed sysdescr match.

type: network
icon: hillstone
group: hillstone
over:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you format the over graphs like the other yaml files please.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, was my yaml format plugin that changed it.

@murrant
Copy link
Member

murrant commented Jan 5, 2018

@alangregory You need to reduce your svg files.

You can use this site: https://jakearchibald.github.io/svgomg/

@laf
Copy link
Member

laf commented Jan 5, 2018

@alangregory Thanks for submitting this :)

Would you mind submitting some additional test data as per https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

Ensure you anonymise the data before you submit it though.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@laf laf merged commit a7aaf11 into librenms:master Jan 8, 2018
@alangregory alangregory deleted the hillstone branch January 25, 2018 14:06
@lock
Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants