New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hillstone StoneOs detection #7982

Merged
merged 15 commits into from Jan 8, 2018

Conversation

Projects
None yet
4 participants
@alangregory
Contributor

alangregory commented Dec 29, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

No svg logo to use?

If not, this logo needs to be square for the devices list. Should be 32x32 ideally.

text: Memory Usage
discovery:
-
sysObjectId: .1.3.6.1.4.1.28557.1

This comment has been minimized.

@laf

laf Dec 29, 2017

Member

Do you need sysDescr as well? Will sysObjectID not be unique enough?

This comment has been minimized.

@alangregory

alangregory Jan 2, 2018

Contributor

I think only Hillstone use this Oid, removed sysdescr match.

type: network
icon: hillstone
group: hillstone
over:

This comment has been minimized.

@laf

laf Dec 29, 2017

Member

Can you format the over graphs like the other yaml files please.

This comment has been minimized.

@alangregory

alangregory Jan 2, 2018

Contributor

Fixed, was my yaml format plugin that changed it.

alangregory added some commits Jan 2, 2018

@murrant

This comment has been minimized.

Member

murrant commented Jan 5, 2018

@alangregory You need to reduce your svg files.

You can use this site: https://jakearchibald.github.io/svgomg/

@laf

This comment has been minimized.

Member

laf commented Jan 5, 2018

@alangregory Thanks for submitting this :)

Would you mind submitting some additional test data as per https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

Ensure you anonymise the data before you submit it though.

@laf

laf approved these changes Jan 5, 2018

alangregory and others added some commits Jan 8, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 8, 2018

The inspection completed: No new issues

@laf laf merged commit a7aaf11 into librenms:master Jan 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@alangregory alangregory deleted the OpcaoTelecom:hillstone branch Jan 25, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.