New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Hillstone StoneOs detection #7982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No svg logo to use?
If not, this logo needs to be square for the devices list. Should be 32x32 ideally.
includes/definitions/stoneos.yaml
Outdated
text: Memory Usage | ||
discovery: | ||
- | ||
sysObjectId: .1.3.6.1.4.1.28557.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need sysDescr as well? Will sysObjectID not be unique enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only Hillstone use this Oid, removed sysdescr match.
type: network | ||
icon: hillstone | ||
group: hillstone | ||
over: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you format the over graphs like the other yaml files please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, was my yaml format plugin that changed it.
@alangregory You need to reduce your svg files. You can use this site: https://jakearchibald.github.io/svgomg/ |
@alangregory Thanks for submitting this :) Would you mind submitting some additional test data as per https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow Ensure you anonymise the data before you submit it though. |
The inspection completed: No new issues |
This thread has been automatically locked since there has not been any recent activity after it was closed. |
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926