New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bgp-peers junos empty afi-safi names #8083

Merged
merged 2 commits into from Jan 21, 2018

Conversation

Projects
None yet
4 participants
@zombah
Contributor

zombah commented Jan 14, 2018

This fixes os junos part of issue #8051
Test data for this case exist in already pending PR #7972
as junos_mx

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf laf added the Blocker 🚫 label Jan 17, 2018

@laf

This comment has been minimized.

Member

laf commented Jan 17, 2018

Blocking until #7972 is merged so we can rebase and test properly.

@laf laf added the Bug 🐞 label Jan 17, 2018

@laf

This comment has been minimized.

Member

laf commented Jan 18, 2018

Sorry @zombah needs a rebase now :(

fix: Bgp-peers junos empty afi-safi names
* fix discovery of all names
* fix polling rrd names assignment

Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
@murrant

This comment has been minimized.

Member

murrant commented Jan 18, 2018

You will need to update test data, since you are changing the polled data.
Run:

./scripts/save-test-data.php -m bgp-peers -o comware
./scripts/save-test-data.php -m bgp-peers -o iosxe
./scripts/save-test-data.php -m bgp-peers -o ios -v 3560g
./scripts/save-test-data.php -m bgp-peers -o junos -v mx
./scripts/save-test-data.php -m bgp-peers -o junos -v ex
./scripts/save-test-data.php -m bgp-peers -o arista_eos

Then review the modifications to data to make sure they are desired.

git diff -- tests/data
Update tests data for junos bgp-peers safi update
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 21, 2018

The inspection completed: No new issues

@zombah

This comment has been minimized.

Contributor

zombah commented Jan 21, 2018

@murrant Added test data update but i can't figure myself why it changes wrong sessions inside json, as i mentioned on discord maybe parsing order changed or something

@murrant

This comment has been minimized.

Member

murrant commented Jan 21, 2018

Looks some fixes changed other OS data . I removed that test data. We'll see if that fixes it.

@murrant murrant merged commit 36fe6c8 into librenms:master Jan 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant removed the Blocker 🚫 label Jan 21, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.