fix: Bgp-peers junos empty afi-safi names

[zombah]

This fixes os junos part of issue #8051
Test data for this case exist in already pending PR #7972
as junos_mx

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

• Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

[laf]

Blocking until #7972 is merged so we can rebase and test properly.

[laf]

Sorry @zombah needs a rebase now :(

[murrant]

You will need to update test data, since you are changing the polled data.
Run:

./scripts/save-test-data.php -m bgp-peers -o comware
./scripts/save-test-data.php -m bgp-peers -o iosxe
./scripts/save-test-data.php -m bgp-peers -o ios -v 3560g
./scripts/save-test-data.php -m bgp-peers -o junos -v mx
./scripts/save-test-data.php -m bgp-peers -o junos -v ex
./scripts/save-test-data.php -m bgp-peers -o arista_eos

Then review the modifications to data to make sure they are desired.

git diff -- tests/data

[scrutinizer-notifier]

The inspection completed: No new issues

[zombah]

@murrant Added test data update but i can't figure myself why it changes wrong sessions inside json, as i mentioned on discord maybe parsing order changed or something

[murrant]

Looks some fixes changed other OS data . I removed that test data. We'll see if that fixes it.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed.