New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the mibs file from vmware #8388

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
6 participants
@mikeSimonson
Contributor

mikeSimonson commented Mar 15, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

CLAassistant commented Mar 15, 2018

CLA assistant check
All committers have signed the CLA.

@laf

This comment has been minimized.

Member

laf commented Mar 15, 2018

You've added a whole heap of new MIBs which are already in the mibs folder. Please remove those from the vmware folder and only have vmware specific mibs there.

@laf laf added the Blocker 🚫 label Mar 15, 2018

@laf

Please see my last comment

@tracernz

This comment has been minimized.

Contributor

tracernz commented Mar 15, 2018

Can you put the source these were retrieved from etc. in the commit message please? It would help a bit for anyone trying to look at how they came to be in future, and is good hygiene in general when pulling in 3rd party sources.

@mikeSimonson

This comment has been minimized.

Contributor

mikeSimonson commented Mar 16, 2018

How do you spot those that are vmware specific ?
Those only come from the vmware archive.

@tracernz

This comment has been minimized.

Contributor

tracernz commented Mar 17, 2018

How do you spot those that are vmware specific ?

VMWARE-*

Those only come from the vmware archive.

Yeah, they included all the generic MIBs their products use too.

@murrant

This comment has been minimized.

Member

murrant commented Mar 20, 2018

You can check this by running:
composer install (to install development dependencies
./vendor/bin/phpunit tests/MibTest.php --group mibs --filter=vmware to check for problems in the vmware mib directory.
./vendor/bin/phpunit tests/MibTest.php --group mibs will check all mibs and also checks for duplicates, but it will also give you a lot of noise because our mibs aren't clean right now :)

@laf

Close, just need to remove these files:

mibs/vmware/README
mibs/vmware/list-ids-diagnostics.txt
mibs/vmware/notifications.txt
mibs/vmware/vc-alarms-65.csv

And rename the other files to remove the .mib extension.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 20, 2018

The inspection completed: No new issues

@laf

laf approved these changes Mar 20, 2018

LGTM. thanks for doing this.

@laf laf merged commit 607a7f8 into librenms:master Mar 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.