Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save-test-data #8399

Merged
merged 1 commit into from Mar 16, 2018
Merged

Fix save-test-data #8399

merged 1 commit into from Mar 16, 2018

Conversation

murrant
Copy link
Member

@murrant murrant commented Mar 16, 2018

But now it buffers all output... and we don't seem to save much from the initial attempt
Needs more testing/thought

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

But now it buffers all output...
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@tracernz
Copy link
Contributor

Just bisected the lack of test data in #8372 to 2bcc766. Is this the fix for that?

git bisect good
2bcc76625ca576aa2aa673b36569c93d2dd758ca is the first bad commit
commit 2bcc76625ca576aa2aa673b36569c93d2dd758ca
Author: Tony Murray <murraytony@gmail.com>
Date:   Wed Mar 14 17:28:01 2018 -0500

    Module tests update: per module output, only store modules data that are run (#8355)
    
    * Test data: don't save data for modules that were not run
    
    * Sometimes mibs are prefixed with +
    
    * Save output for each module and only output the errored module.
    Also makes it easier to identify modules that were ran.
    
    * Clean up json files.
    Message when no module data exists.
    
    * verbose output when phpunit --debug is used
    order by for ports
    avoid graphite output in tests
    only load module_tables.yaml once
    
    * use explode and strpos instead of regex since it is failing...
    
    * Fix some warnings
    
    * Fix whitespace

:040000 040000 0a9bcb49eefa5ca08c81cda16d3b2bfff274983d 66f60f6d56b9c2c955ee24af0d328c88e286677b M	LibreNMS
:040000 040000 2d98427cc4a0bc52d7c6580abf0493a588f14e1c 6314fa93aad8b11fdb6558453b0013b1f857ede2 M	includes
:040000 040000 09800aa63c96da1c829d335cca6e9becd48a00db 78414df3b68055d5cb9170875f86def516a3a05d M	tests

@tracernz
Copy link
Contributor

Yes, I get test data again with this patch. 👍

@tracernz tracernz mentioned this pull request Mar 16, 2018
1 task
@laf laf merged commit 3cd6d90 into librenms:master Mar 16, 2018
@murrant murrant deleted the fix-save-test-data branch March 16, 2018 12:05
@lock
Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants