New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Improved detection for dlink and dlinkap devices #8447

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Mar 21, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #8190

Fundamentally changes the detection for these devices. I've used the data from stats and this should be fine.

@laf laf added the Device 🖥 label Mar 21, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 21, 2018

The inspection completed: No new issues

@murrant murrant merged commit 4c2822f into librenms:master Mar 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:device/issue-8190 branch Mar 25, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.