Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Total Wireless Client and AP count for Ruckus Wireless OS Type #8503

Merged
merged 7 commits into from Apr 7, 2018
Merged

Add Total Wireless Client and AP count for Ruckus Wireless OS Type #8503

merged 7 commits into from Apr 7, 2018

Conversation

djamp42
Copy link
Contributor

@djamp42 djamp42 commented Apr 3, 2018

Add Total Authorized Clients and Total AP Connected to Ruckus Wireless OS. Tested on Zone Director 1200 & 1100.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Add Total Authorized Clients and Total AP Connected to Zone Director, Tested on Zone Director 1200 & 1100.
@djamp42 djamp42 changed the title Create Ruckuswireless.php Add Total Wireless Client and AP count for Ruckus Wireless OS Type Apr 3, 2018
@laf
Copy link
Member

laf commented Apr 4, 2018

Thanks for this. Can you add test data as well so we can ensure nothing breaks in the future: https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

@djamp42
Copy link
Contributor Author

djamp42 commented Apr 5, 2018

I ran the following, but it keeps generating the same filename with the same data for all my zone directors. i'm assuming i can't really add any more test data then what is already provided.

./scripts/collect-snmp-data.php -h #.#.#.# -m os -v

 Module(s): os

Capturing Data:  sysDescr.0 sysObjectID.0 sysName.0 SNMPv2-MIB::sysDescr.0 SNMPv2-MIB::sysObjectID.0 .1.3.6.1.4.1.12148.10.2.6.0 sysUpTime.0 sysLocation.0 sysContact.0 snmpEngineTime.0 hrSystemUptime.0 .1.3.6.1.4.1.25053.3.1.5.15.5.0 .1.3.6.1.4.1.25053.3.1.5.15.8.0 .1.3.6.1.4.1.25053.3.1.5.15.7.0 .1.3.6.1.4.1.25053.3.1.5.15.9.0

Updated snmprec data /opt/librenms/tests/snmpsim/ruckuswireless.snmprec

Verify this file does not contain any private data before submitting!

@laf
Copy link
Member

laf commented Apr 5, 2018

Yeah just add -v model_name to that command, you can then create a new file per model.

1 is fine though.

@djamp42
Copy link
Contributor Author

djamp42 commented Apr 5, 2018

Created, also added the AP Count /Client over graphs for the ruckuswireless os type. Let me know if anything else is needed.

@murrant
Copy link
Member

murrant commented Apr 6, 2018

@djamp42 That's correct, but I think it would be good to add other data besides just os.

Run collect-snmp-data.php again without -m os Thanks.

@djamp42
Copy link
Contributor Author

djamp42 commented Apr 6, 2018

Okay no problem updated the files.

@scrutinizer-notifier
Copy link

The inspection completed: 3 updated code elements

Copy link
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laf laf merged commit a3f822b into librenms:master Apr 7, 2018
TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018
…OS Type (librenms#8503)

* Create Ruckuswireless.php

Add Total Authorized Clients and Total AP Connected to Zone Director, Tested on Zone Director 1200 & 1100.

* Update Ruckuswireless.php

* Create ruckuswireless_zd1200.snmprec

* Create ruckuswireless_zd1100.snmprec

* Add AP count and Wireless Client over graphs

* Update ruckuswireless_zd1200.snmprec

* Update ruckuswireless_zd1100.snmprec
@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
@djamp42 djamp42 deleted the patch-4 branch March 20, 2019 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants