New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Apc - Humidity sensor negative value filtering #8743

Merged
merged 1 commit into from May 20, 2018

Conversation

Projects
None yet
2 participants
@PipoCanaja
Contributor

PipoCanaja commented May 20, 2018

Hello

We have PDUs (APC) that were returning "-1" as Humidity value, and it seems that this happens when the optional humidity sensor is not plugged into the PDU.
This PR is adding a check to skip the negative values.

Bye
PipoCanaja

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@PipoCanaja PipoCanaja changed the title from Bug - Apc humidity negative value filtering to Bug - Apc - Humidity sensor negative value filtering May 20, 2018

@laf

laf approved these changes May 20, 2018

LGTM

@laf laf merged commit 0b9bcbf into librenms:master May 20, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the Bug 🐞 label May 20, 2018

@PipoCanaja PipoCanaja deleted the PipoCanaja:APC_HumidityValidity branch May 20, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

fix: Apc humidity sensors negative value filtering (librenms#8743)
Hello

We have  PDUs (APC) that were returning "-1" as Humidity value, and it seems that this happens when the optional humidity sensor is not plugged into the PDU. 
This PR is adding a check to skip the negative values.

Bye
PipoCanaja

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

@lock lock bot locked as resolved and limited conversation to collaborators Jul 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.