Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited text on the edit device page for Disable Polling and Ignore Al… #8900

Closed
wants to merge 1 commit into from

Conversation

okayryan
Copy link

…e Alerts to make it easier for web ui users.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


okayryan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kkrumm1 kkrumm1 added the WebUI label Jul 16, 2018
@laf
Copy link
Member

laf commented Jul 16, 2018

Thanks for this.

IMHO I think the clarification of this belongs in the docs really. Disable doesn't just disable polling so it's a bit misleading if we say it does. Same for ignore.

@laf
Copy link
Member

laf commented Aug 3, 2018

@okayryan Any response on this?

@laf laf added the Needs-Info label Aug 3, 2018
@laf
Copy link
Member

laf commented Aug 11, 2018

@okayryan Feel free to respond to this PR and we can re-open.

@laf laf closed this Aug 11, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants