Add temp polling for IBM Flexsystem switches #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Rosiak
commented
May 1, 2015
Rosiak
commented
- Able to poll temps from IBM Flexsystem switches
- Convert temp response to digit
- Able to poll temps from IBM Flexsystem switches - Convert temp response to digit
|
One Scrutinizer issue that would be worth fixing: "The expression $check_oids of type false|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead. " |
- Updated to fit suggestions from scrut
|
Updated! Lafwood is testing the polling convert change, he'll merge when he's done testing. |
- Add extra safety check
laf
added a commit
that referenced
this pull request
May 3, 2015
Add temp polling for IBM Flexsystem switches
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.