New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeps the dashboard sessions from expiring. #9263

Merged
merged 2 commits into from Oct 1, 2018

Conversation

Projects
None yet
1 participant
@murrant
Member

murrant commented Sep 26, 2018

Route dashboard ajax calls through Laravel.
Boots minimal cookies and sessions.
This is a workaround and does not fix the issue.
Does not fix other pages for now, real fix is to fully port.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Keeps the dashboard sessions from expiring.
Route dashboard ajax calls through Laravel.
Boots minimal cookies and sessions.
Does not fix other pages for now, real fix is to fully port.

@murrant murrant added the WebUI label Sep 26, 2018

@murrant murrant added this to the 1.44 milestone Sep 26, 2018

Check Laravel auth for the legacy calls.
Display Laravel errors in the dashboard.
legacy auth checks are mostly extraneous now.

@murrant murrant merged commit 14a168b into librenms:master Oct 1, 2018

3 of 4 checks passed

codeclimate 1 issue to fix
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:dual-session branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment