New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force root url if set by user #9266

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Sep 26, 2018

If user sets APP_URL, force the root url to that. Empty strings result in default behavior.
Fix some of the urls in the laravel templates.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Force root url if set by user
If user sets APP_URL, force the root url to that.  Empty strings result in default behavior.
Fix some of the urls in the laravel templates.

@murrant murrant added the WebUI label Sep 26, 2018

murrant added some commits Sep 26, 2018

@murrant murrant added this to the 1.44 milestone Sep 29, 2018

@murrant murrant merged commit 421bcb0 into librenms:master Oct 2, 2018

4 checks passed

WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:proxy-links branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment