Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force root url if set by user #9266

Merged
merged 3 commits into from
Oct 2, 2018
Merged

Force root url if set by user #9266

merged 3 commits into from
Oct 2, 2018

Conversation

murrant
Copy link
Member

@murrant murrant commented Sep 26, 2018

If user sets APP_URL, force the root url to that. Empty strings result in default behavior.
Fix some of the urls in the laravel templates.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

If user sets APP_URL, force the root url to that.  Empty strings result in default behavior.
Fix some of the urls in the laravel templates.
@murrant murrant added the WebUI label Sep 26, 2018
@murrant murrant added this to the 1.44 milestone Sep 29, 2018
Copy link
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murrant murrant merged commit 421bcb0 into librenms:master Oct 2, 2018
@laf laf deleted the proxy-links branch October 3, 2018 20:46
@lock lock bot locked as resolved and limited conversation to collaborators Dec 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants