New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call to legacy auth to get dashboards. #9297

Merged
merged 1 commit into from Oct 6, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Oct 4, 2018

Can cause a lot of ldap calls for example.
Should improve dashboard page load time on certain auth methods.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the WebUI label Oct 4, 2018

@laf

laf approved these changes Oct 6, 2018

Tested on mysql auth. Still works ok.

@laf laf merged commit 7c09f69 into librenms:master Oct 6, 2018

4 checks passed

WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:dont-legacy-auth-dash branch Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment