Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arista interface bias current divisor #9728

Merged
merged 3 commits into from Feb 7, 2019

Conversation

Rosiak
Copy link
Member

@Rosiak Rosiak commented Jan 24, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Divisor issue caused by #7156

This is incorrect on newer Arista versions(I guess the bug has been fixed in the OS).
Tested on EOS 4.20.8M & 4.21.3F

I think we should remove this workaround and advise users to upgrade, if asked.
Otherwise we are required to maintain a list of bugfree/working versions.

@Rosiak
Copy link
Member Author

Rosiak commented Jan 31, 2019

I assume we're good on this? :)

Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murrant murrant merged commit 80f31b4 into librenms:master Feb 7, 2019
@murrant murrant added Alerting 🔔 Device 🖥️ New or added device support labels Mar 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Alerting 🔔 Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants