Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arista interface bias current divisor #9728

Merged
merged 3 commits into from Feb 7, 2019

Conversation

Projects
None yet
2 participants
@Rosiak
Copy link
Contributor

commented Jan 24, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Divisor issue caused by #7156

This is incorrect on newer Arista versions(I guess the bug has been fixed in the OS).
Tested on EOS 4.20.8M & 4.21.3F

I think we should remove this workaround and advise users to upgrade, if asked.
Otherwise we are required to maintain a list of bugfree/working versions.

Rosiak and others added some commits Jan 24, 2019

@Rosiak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

I assume we're good on this? :)

@murrant

murrant approved these changes Feb 7, 2019

Copy link
Member

left a comment

LGTM

@murrant murrant merged commit 80f31b4 into librenms:master Feb 7, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

sjtarik added a commit to sjtarik/librenms that referenced this pull request Feb 19, 2019

Fix Arista interface bias current divisor (librenms#9728)
* Remove exception

* Add test data

* Update arista_eos.json

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fix Arista interface bias current divisor (librenms#9728)
* Remove exception

* Add test data

* Update arista_eos.json

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.