Revert "Mattermost Alert Transport" #9743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheGreatDoc
added
Bug 🕷️
Ignore changelog 🔇
|
@gpant if you dont mind doing a new PR but without removing the .htaccess files ;) Also, the PR removes html/includes/collectd/config.php and resources/views/alerts/templates/default.blade.php Im pretty sure that shouldnt be there |
|
@TheGreatDoc I will re submit the PR using git directly, I didn't notice vscode did that in the second commit I am really sorry. |
|
@TheGreatDoc and why you reverted #9673? It seems it is different PR |
|
@zombah I didnt reverted 9673. I dont know why its referenced, but did not reverted that one. |
|
Yes revert commit is empty, didn't noticed, sorry for the noise |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9711
Due to that PR removing .htaccess files and making unable to load webui