Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meraki MS: add serial number #9768

Merged
merged 6 commits into from Mar 6, 2019

Conversation

GitStoph
Copy link
Contributor

@GitStoph GitStoph commented Jan 31, 2019

added line to merakims.inc.php to properly code serial # in devices table

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@GitStoph
Copy link
Contributor Author

Tested this on 4 models of MS switches we deploy, and it worked correctly for each.

@PipoCanaja PipoCanaja added the Device 🖥️ New or added device support label Feb 2, 2019
@PipoCanaja
Copy link
Contributor

Hi @GitStoph
Thanx for your PR. Could you please also take care of test data ? If you have multiple types of devices, you could even create a few variants of them in order to improve the regression tests.
Thanx

@PipoCanaja PipoCanaja added the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Feb 2, 2019
@GitStoph
Copy link
Contributor Author

GitStoph commented Feb 2, 2019

Hi @GitStoph
Thanx for your PR. Could you please also take care of test data ? If you have multiple types of devices, you could even create a few variants of them in order to improve the regression tests.
Thanx

Hi @PipoCanaja ,
I know what all of those words mean individually, but together in this scenario I'm unsure what you're asking of me? I'm not very familiar with PHP, or project management with it.

I do have quite a few different Meraki models in our deployment. Is there an outline of the process you're asking of me that you could link me to? I could try to knock it out during slow time at work? Sorry I'm not more knowledgeable on the subject.

Thanks-

@PipoCanaja
Copy link
Contributor

My bad, I forgot to add the link :) You can start with this page, and let me know if you need more help.
https://github.com/librenms/librenms/blob/master/doc/Developing/os/Test-Units.md

@murrant murrant added the User-Pending Currently waiting for user response label Feb 7, 2019
@PipoCanaja PipoCanaja added Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ and removed Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Feb 25, 2019
@label-actions
Copy link

label-actions bot commented Feb 25, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@murrant murrant changed the title added line to merakims.inc.php to properly code serial # in devices t… Meraki MS: add serial number Mar 5, 2019
@murrant murrant removed Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ User-Pending Currently waiting for user response labels Mar 5, 2019
murrant
murrant previously approved these changes Mar 5, 2019
@murrant murrant merged commit a114d98 into librenms:master Mar 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants