Printer paper tray status and error states #9859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good overall @sjtarik Can we try to add test data for these? |
murrant
added
Feature
Device 🖥️
|
Please add test data so we can ensure your change is not broken in the future. Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units |
murrant
reviewed
Mar 2, 2019
includes/discovery/toner.inc.php
Outdated
| d_echo($tray_oids); | ||
| foreach ($tray_oids as $index => $data) { | ||
| $last_index = substr($index, strrpos($index, '.') + 1); | ||
| $type = 'jetpapertray'; |
There was a problem hiding this comment.
Can probably drop jet here and just go papertray (jetdirect above is for legacy reasons)
|
Polling code looks nice, but I think it might be nice to have separate boxes for them in the webui. You could split them out using the type field. |
|
I modified this to capture type data and display it a bit nicer in the webui:
|
murrant
removed
the
Needs Tests 🦄
|
that looks great @murrant. printer support needed some love and now it gets a lot of it :) great progress. |
murrant
changed the title
murrant
approved these changes
Mar 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.