Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Device - Cisco Sat Receivers #9899

Merged
merged 8 commits into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@djamp42
Copy link
Contributor

commented Mar 4, 2019

Add Support for Cisco Sat. Receivers (D9858,9859,9854,etc).

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

djamp42 added some commits Mar 4, 2019

@murrant murrant added the Device 🖥 label Mar 4, 2019

@murrant

murrant approved these changes Mar 4, 2019

Copy link
Member

left a comment

Nice one :)

@murrant murrant merged commit 8c5f86f into librenms:master Mar 4, 2019

5 of 6 checks passed

codeclimate 8 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@djamp42 djamp42 deleted the djamp42:sa-sat-receviers branch Mar 20, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Add Device - Cisco Sat Receivers (librenms#9899)
* Cisco Sat Receiver

* Formatting Fixes

* Code Climate Fixes

* Add $entry field in the last array.

* Formatting Fixes

* Updated to correct S/N was grabbing wrong OID.

* Update test data for missing serial #

* Updated Serial # test data

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.