Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widgets page with MySQL 8 #9922

Merged
merged 1 commit into from Mar 8, 2019
Merged

Conversation

llcoolkm
Copy link
Contributor

@llcoolkm llcoolkm commented Mar 8, 2019

…introduced in MySQL 8.0.2. Reference: https://dev.mysql.com/doc/refman/8.0/en/keywords.html

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just need to sign the CLA

@murrant murrant added the WebUI label Mar 8, 2019
@murrant murrant changed the title Quoted all column names to avoid breakage for reserved keyword "row" … Fix widgets page with MySQL 8 Mar 8, 2019
@murrant murrant merged commit 6eda5ee into librenms:master Mar 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants