-
Notifications
You must be signed in to change notification settings - Fork 588
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Played song in mobile client not updated #157
Comments
It seems not to be dependent on where the songs are from. The currently playing song in the client app is just not updated. The android mobile is a quite recent one, the w-lan router was 1m away, so network should not be the problem. Another test. Started on the Linux PC librespotd and the original Spotify application, angain Android mobile as client. The connection works fine if I choose the original Spotify application as the target. Choosing librespotd again as the target, I have the problem again. |
Are these two albums within the same playlist or two totally different albums? Please provide the exact steps to reproduce this. Also we need the versions of both the android client (it's under settings) and librespot. |
It seems to work instead, if I always pause the currently playing song, before selecting another one from the library. |
Spotify client version (Android) 8.4.39.673 |
Yep OK I now have the same version of the Spotify client as you and I can reproduce this. I've tried older versions of librespot that definitely used to work properly in regards to this but they all now behave like this. So it looks like Spotify changed something and the official clients are no longer picking up the librespot status messages. I guess it might be interesting to see how old Connect hardware behaves with this these updated clients. |
Thank you for your investigations. Do you know a version number still working? |
No, I can't find a working one anymore |
OK, now I am really confused, I restarted my phone and it's now started working properly again.... (with the latest code) |
@kingosticks The fix you have pushed in your recent PR (#156) does fix this issue. I had the same problem, but now after recompiling it, it's gone. |
There is no fix in that PR for this. I'd say it's more likely the recompiling that's fixed it. |
And hopefully we can close this now. |
I bet, this is the fixing line: https://github.com/librespot-org/librespot/pull/156/files#diff-fb4606287b6e129f05bf85e440522421R635 That's mainly what's missing. Spotify never knew, in which playlist the current song had been located. But, it knew, which song had been playing. This resulted also in the mobile app, not updating the tracks, because the mobile view actually does not show the current track. In fact it's showing you the current track of the playlist in context. This resulted in weird issues like this: On your laptop client, you play And on the mobile, the really weird behavior starts here: If you go on and skip to a certain timepoint on Android e.g.
Recompiling doesn't fix anything. Of course, I pulled from 4f3a594 to 685fb4e before recompiling. |
Include updating context_uri along with tracks and current index
@bebehei I just tried to reproduce that wierd behaviour on my devices, but was unable to reproduce. I also tried with an iOS device, with Android and OS X app open, and was similarly unable to reproduce. Have you tried resetting to the master HEAD, deleting the |
I can confirm that this issue is fixed, now. After updating my repository and rebuilding it worked as expected. Additionally switching between and older build and this one confirms it (old one has the issue, new build don't). Thank you! I think I should close it now. |
I've had reports of users claiming that they started to see this or a similar issue suddenly one day after updating their Android app. But not right after the update, only a few additional days later. Reverting to an older app version "fixed" it. IMHO this looks like a temporary issue on Spotify's end. Like they changed a few things in the app as well as the back-end which caused problems. And at some point they figured it out and fixed the server side again. |
If it has nothing to with the latest changes, it must be some kind of side effect, or dependent on the build. |
How odd. Anyway, looks like it's quashed for now. |
With the build from @awiouy the problem is solved now on my Wetek Play2 (Kodi,LibreElec) as well |
I've tried a Panasonic All-1C versus the mentioned spotify client and higher - same problem. A lot of customers will be unhappy! |
I played around a while with librespotd on kodi and with the current state on my linux machine. It is great stuff, but still one question. If I control it from my mobile the songs displayed on the mobile are fast out of sync with the actually played ones. E.g. start one song from an album, choose librespotd for audio output, than choose another song (from another album). The other song is playing, but the old song/album is still shown on the mobile. Jumping to the next song, the next song from the other album is playing, but the mobile is displaying the next song from the first album. Am I doing something wrong or is this as it is currently?
The text was updated successfully, but these errors were encountered: