Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/clippy #1284

Merged
merged 6 commits into from
May 27, 2024
Merged

Fix/clippy #1284

merged 6 commits into from
May 27, 2024

Conversation

yubiuser
Copy link
Contributor

Fixes the clippy warning that occur with v1.78. being the new stable. This made the test fail (e.g here).
Addressed the following warnings:

Sidenote: set the environment variables RUST_BACKTRACE and RUSTFLAGS in the devcontainer the same as they are in the github action workflow file.

@yubiuser
Add rust env variables to devcontainer
5fc8d2d 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Fix assigning_clones
0884a0d 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Set MSRV in Cargo.toml files to 1.71
ca035c9 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Fix derivable_impls
99878e0 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Fix clippy::to_string_trait_impl
27d3c9e 
Signed-off-by: Christian König <ckoenig@posteo.de>
@lelloman lelloman mentioned this pull request May 23, 2024
Merged
roderickvd
roderickvd reviewed May 26, 2024
View reviewed changes
Copy link
Member

@roderickvd roderickvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small request do keep it DRY.

core/src/mercury/types.rs Outdated Show resolved Hide resolved
core/src/session.rs Show resolved Hide resolved
@yubiuser
Apply reviewer's suggestion
2a8c4bd 
Signed-off-by: Christian König <ckoenig@posteo.de>
@roderickvd
Copy link
Member

Perfect, thanks!

@roderickvd roderickvd merged commit 8f9bec2 into librespot-org:dev May 27, 2024
9 checks passed
@yubiuser yubiuser deleted the fix/clippy branch May 27, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roderickvd roderickvd roderickvd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yubiuser @roderickvd