Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format according to rustfmt guidelines #165

Merged
merged 2 commits into from
Feb 26, 2018
Merged

Format according to rustfmt guidelines #165

merged 2 commits into from
Feb 26, 2018

Conversation

sashahilton00
Copy link
Member

These changes were generated by running cargo fmt --all against the project. Will let Travis build to confirm all is good, then merge.

@plietar
Copy link
Contributor

plietar commented Feb 25, 2018

Can you update .travis.yml to test this

@sashahilton00
Copy link
Member Author

@plietar it looks to already do checking to a certain extent. https://github.com/librespot-org/librespot/blob/master/.travis.yml#L25

I'm running fmt in stable rust atm, Do you want me to just modify the travis script to run cargo fmt --all -- --write-mode diff for all rust versions except 1.20.0?

@plietar
Copy link
Contributor

plietar commented Feb 25, 2018

I thought stable didn't work yet (#159).
I'm just talking about changing --package=librespot-core to --all

@sashahilton00
Copy link
Member Author

It doesn't work yet, in the sense that one gets the warnings, but since they're warnings, it's not going to cause a build to fail. Still, will leave it as nightly only until it's fully compatible with the stable release. Will push a commit for the travis update in a bit, just working on #130 atm.

@sashahilton00
Copy link
Member Author

Will rework this once #166 is done

@sashahilton00 sashahilton00 reopened this Feb 26, 2018
@sashahilton00 sashahilton00 merged commit aa880f8 into master Feb 26, 2018
@sashahilton00 sashahilton00 deleted the rustfmt branch February 26, 2018 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants