review windows warnings #966
Comments
You can't pass a function pointer through a void pointer. So wrap the pthread callback in a struct. Fixes libressl#966
|
one more like that |
|
... and more |
|
Yes, thanks. I saw them
this test needs reworking. I've added it to my to do list. |
|
I've added build artifacts, entire build folder is added to artifacts
no idea what empty.c is either.
|
|
To silence the chacha warnings, something like this can be done: - static const char sigma[16] = "expand 32-byte k";
+ static const char sigma[16] = { 'e', 'x', 'p', 'a', 'n', 'd', ' ', '3',
+ '2', '-', 'b', 'y', 't', 'e', ' ', 'k' }; |
|
On Wed, Dec 13, 2023 at 08:19:24AM -0800, Viktor Szakats wrote:
To silence the chacha warnings, something like this can be done:
```diff
- static const char sigma[16] = "expand 32-byte k";
+ static const char sigma[16] = { 'e', 'x', 'p', 'a', 'n', 'd', ' ', '3',
+ '2', '-', 'b', 'y', 't', 'e', ' ', 'k' };
```
Yes, but that's also ugly and I don't think we should do this. See also
#955
|
|
for ugly things we have "pragma" )) |
|
To me the ugly solution reduces the ambigiuty when reading the code. The string is just a bunch of bytes, not meant for reading or grepping. Another solution is to bump its size to As for this one: It'd be useful to know what exact CMake issue (and which Generator) made this necessary. Other than that, this warning may happen when the whole source content is guarded out legitimately, leaving an empty object. It think it's safe to silence, or ignore. If that's the only source affected, it'd be better to fix the CMake root issue though. |
You can't pass a function pointer through a void pointer. So wrap the pthread callback in a struct. Fixes libressl#966
You can't pass a function pointer through a void pointer. So wrap the pthread callback in a struct. Fixes libressl#966
while working on automatic release, I noticed a lot of build warnings under windows.
let's review them.
either we can
The text was updated successfully, but these errors were encountered: