Build of manpages is broken: missing xmlto is tolerated, and in case xmlto is present they aren't installed

[yurivict]

Build sometimes fails when xmlto is missing (see log http://beefy18.nyi.freebsd.org/data/main-amd64-default/pe8cfea34d340_s47aeda7b70/logs/libreswan-4.4.log (IPv6 URL)). Sometimes missing xmlto is solently tolerated.

Manpages aren't installed.

[cagney]

"sometimes"?

sed -e "s:@IPSECVERSION@:4.4:g" -e "/@freebsd_START@/,/@freebsd_END@/d" -e "s:@OSDEP@:freebsd:g" -e "s:@EXAMPLECONFDIR@:/usr/local/share/doc/libreswan:g" -e "s:@FINALCONFDDIR@:/usr/local/etc/ipsec.d:g" -e "s:@FINALCONFDIR@:/usr/local/etc:g" -e "s:@FINALCONFFILE@:/usr/local/etc/ipsec.conf:g" -e "s:@FINALDOCDIR@:/usr/local/share/doc/libreswan:g" -e "s:@FINALEXAMPLECONFDIR@:/usr/local/share/doc/libreswan:g" -e "s:@FINALLIBEXECDIR@:/usr/local/libexec/ipsec:g" -e "s:@FINALLOGDIR@:/var/log:g" -e "s:@FINALLOGROTATEDDIR@:/usr/local/etc/logrotate.d:g" -e "s:@FINALINITDDIR@:/etc/init.d:g" -e "s:@FINALSBINDIR@:/usr/local/sbin:g" -e "s:@FINALSYSCONFDIR@:/usr/local/etc:g" -e "s:@FINALVARDIR@:/var:g" -e "s:@IPSEC_CONF@:/usr/local/etc/ipsec.conf:g" -e "s:@IPSEC_CONFDDIR@:/usr/local/etc/ipsec.d:g" -e "s:@IPSEC_RUNDIR@:/var/run/pluto:g" -e "s:@IPSEC_NSSDIR@:/usr/local/etc/ipsec.d:g" -e "s:@IPSEC_PPKDIR@:/usr/local/etc/ipsec.d:g" -e "s:@IPSEC_EXECDIR@:/usr/local/libexec/ipsec:g" -e "s:@IPSEC_VARDIR@:/var:g" -e "s:@IPSEC_SBINDIR@:/usr/local/sbin:g" -e "s:@IPSEC_SECRETS_FILE@:/usr/local/etc/ipsec.secrets:g" -e "s:@MODPROBEBIN@:modprobe:g" -e "s:@MODPROBEARGS@:--quiet --use-blacklist:g" -e "s:@PYTHON_BINARY@:/usr/local/bin/python3.8:g" -e "s:@SHELL_BINARY@:/bin/sh:g" -e "s:@USE_DEFAULT_CONNS@::g" -e "s:@SD_TYPE@:simple:g" -e "s:@SD_RESTART_TYPE@::g" -e "s:@SD_PLUTO_OPTIONS@::g" -e "s:@SD_WATCHDOGSEC@:0:g" -e "s:@INITSYSTEM@:rc.d:g" -e "s:@DOCKER_PLUTONOFORK@:--nofork:g"  < ipsec_pluto.8.xml > ../../OBJ.freebsd.amd64/programs/pluto/ipsec_pluto.8.tmp.tmp
mv ../../OBJ.freebsd.amd64/programs/pluto/ipsec_pluto.8.tmp.tmp ../../OBJ.freebsd.amd64/programs/pluto/ipsec_pluto.8.tmp
: ignoring seemingly bogus xmlto exit status
xmlto man ../../OBJ.freebsd.amd64/programs/pluto/ipsec_pluto.8.tmp -o ../../OBJ.freebsd.amd64/programs/pluto || true
/bin/sh: xmlto: not found
test -z ""  -a -r ../../OBJ.freebsd.amd64/programs/pluto/ipsec_pluto.8  -a -r ../../OBJ.freebsd.amd64/programs/pluto/ipsec_whack.8  -a -r ../../OBJ.freebsd.amd64/programs/pluto/pluto.8
gmake[4]: *** [../../mk/manpages.mk:82: ../../OBJ.freebsd.amd64/programs/pluto/ipsec_pluto.8.man] Error 1
gmake[4]: *** Waiting for unfinished jobs....
gmake[3]: *** [../../mk/targets.mk:82: all] Error 2
gmake[3]: Leaving directory '/wrkdirs/usr/ports/security/libreswan/work/libreswan-4.4/programs/pluto'
gmake[2]: *** [../mk/targets.mk:82: recursive-all] Error 2
gmake[2]: Leaving directory '/wrkdirs/usr/ports/security/libreswan/work/libreswan-4.4/programs'
gmake[1]: *** [/wrkdirs/usr/ports/security/libreswan/work/libreswan-4.4/mk/targets.mk:82: recursive-all] Error 2
gmake[1]: Leaving directory '/wrkdirs/usr/ports/security/libreswan/work/libreswan-4.4'

This works as expected. The comment that goes with the build rule reads:

# Note: XMLTO seems to fail even when it succeeds so ignore the exit
# status and instead explicitly check for the expected output files.

Is there a case where the xmlto is missing yet the build succeeds?

[yurivict]

Is there a case where the xmlto is missing yet the build succeeds?

Yes, xmlto was missing in the port, but build succeeded on FreeBSD {12,13} and failed on FreeBSD 14.

On FreeBSD {12,13} it wasn't installing manpages without xmlto.

[cagney]

Is there a log?

[yurivict]

https://people.freebsd.org/~yuri/libreswan.log

[cagney]

(I wondered if this was 'cos of awk)
With the s/awk/gawk/ patch applied, does the build fail?
(it isn't a solution but is a useful data point)

[cagney]

Assuming it does fail, I think this can be closed. The root cause is that refnames.sh barf wasn't detected. Which is bug 480

[yurivict]

With awk=gawk and no xmlto it does fail.