sort all wildcarded object files for reproducibility #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this sort, the linker may assemble the final object files in the order in which their source files are found in the filesystem (or however make chooses to interpret the $(wildcard ...) function). By sorting the results lexicographically, we aim to assemble byte-identical output files, regardless of the filesystem order or other possible non-determinism introduced by make.
|
merged, thanks! |
libreswan
pushed a commit
that referenced
this pull request
Oct 23, 2018
Without this sort, the linker may assemble the final object files in the order in which their source files are found in the filesystem (or however make chooses to interpret the $(wildcard ...) function). By sorting the results lexicographically, we aim to assemble byte-identical output files, regardless of the filesystem order or other possible non-determinism introduced by make. This resolves #217 Signed-off-by: Paul Wouters <pwouters@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this sort, the linker may assemble the final object files in
the order in which their source files are found in the filesystem (or
however make chooses to interpret the $(wildcard ...) function).
By sorting the results lexicographically, we aim to assemble
byte-identical output files, regardless of the filesystem order or
other possible non-determinism introduced by make.
(i've applied this patch to the debian packaging of libreswan between versions 3.27-3 and 3.27-4; results: 3.27-3 is non-deterministically unreproducible, and 3.27-4 appears to be reliably reproducible)