Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support >= php8.0 #2047

Open
jooola opened this issue Aug 12, 2022 · 5 comments
Open

Support >= php8.0 #2047

jooola opened this issue Aug 12, 2022 · 5 comments
Labels
dependencies This is affecting the dependencies help wanted Extra attention is needed is: feature-request php

Comments

@jooola
Copy link
Contributor

jooola commented Aug 12, 2022

We currently only support php7.2 -> php7.4. To install LibreTime on recent distributions using the php distribution packages, we will have to support >=php8.0.

A work around would be to install php7.4 from the php sury repository.

Most of our dependencies support php8.0, but we are using some abandoned dependencies that needs upgrading as well or replacements:

Test dependencies:

  • phpunit/dbunit I wonder if we should drop or fork this.
  • phpunit/phpunit zf1s seem to be maintain a phpunit version for testing their work https://github.com/zf1s/phpunit with php8.0

Probably some other dependencies (indirect) that also needs some upgrading.

Related to #1845 #777

Feel free to pick this issue and help us support php8.0 ! Help is greatly appreciated !

@jooola jooola added help wanted Extra attention is needed php is: feature-request dependencies This is affecting the dependencies labels Aug 12, 2022
@jooola jooola changed the title Support >=php8.0 Support >= php8.0 Aug 12, 2022
@jooola
Copy link
Contributor Author

jooola commented Aug 12, 2022

I don't know if we want to only support >= php8.0 once this is implemented. As it would probably make our life easier. Though support for 7.4 and 8.x should be doable, but as php7.2 and 7.3 will be dropped with #2035 and #2036

@jooola
Copy link
Contributor Author

jooola commented Dec 7, 2022

Some progress was made that we start trying to use:

@willvincent
Copy link

I don't know if we want to only support >= php8.0 once this is implemented. As it would probably make our life easier.

Considering 7.4 became EOL on January 1st, yes, only php8 should be supported moving forward. :)

@paddatrapper
Copy link
Contributor

Dropping 7.4 support requires dropping support for the distros that ship it, so it is more of a discussion that just drop it because upstream dropped it. Distro maintainers still provide support even if upstream doesn't

@jooola
Copy link
Contributor Author

jooola commented Jan 16, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This is affecting the dependencies help wanted Extra attention is needed is: feature-request php
Projects
None yet
Development

No branches or pull requests

3 participants