Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hideable Scheduled Shows tab #106

Merged
merged 2 commits into from
Mar 23, 2017

Conversation

hairmare
Copy link
Member

Makes the first tab remoeable and the tracks page be full width after removing the last tab. You can press the "Dashboard" link to open it back up again.

Makes the first tab remoeable and the tracks page be full width after removing the last tab. You can press the "Dashboard" link to open it back up again.
@Robbt
Copy link
Member

Robbt commented Mar 22, 2017

It works but I think that the UI could a little bit improved. From what I saw there was only 3 dots to the right of scheduled shows. I think that it might be better to have an arrow or some other indicator. I also noticed that the area I could click on was somewhat limited.

@hairmare
Copy link
Member Author

It should be an X on the tab like the other tabs have. The three dots happens when the text doesn't fit. Maybe I missed some CSS. I'll have a closer look at it.

@hairmare
Copy link
Member Author

hairmare commented Mar 23, 2017

This is what it should look like:

screen shot 2017-03-23 at 11 24 45

If the text is clipped a bit and showing dots your browser might still have a cached version of the css changed by this. I had to do a lot of Cmd-Shift-R reloading to hack on the css.

@Robbt
Copy link
Member

Robbt commented Mar 23, 2017

Ok, in the dashboard.css I needed to change the max-width to 160px vs. 140px to get it to show.
I figure this is probably something with Firefox vs. Chrome.

I can't do the push right now but here is the section that needs to change from my testing.

.tab-name {
float: left;
max-width: 160px;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}

@hairmare
Copy link
Member Author

I'll give both a try and apply it.

@hairmare
Copy link
Member Author

hairmare commented Mar 23, 2017

I wasn't able to reproduce it, maybe my Firefox Aurora install is too hipster for it. I did the change anyway since a larger max-width shouldn't hurt.

@Robbt Robbt merged commit 69347f2 into libretime:master Mar 23, 2017
@hairmare hairmare deleted the feature/hideable-scheduled-shows branch March 23, 2017 19:47
@lock
Copy link

lock bot commented Oct 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please chat to us on discourse or ask for help on our chat if you have any questions or need further assistance with this issue.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants