Fixing dependence upon hard-coded password in AutoPlaylist #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to not require authentication
hairmare
previously requested changes
Mar 21, 2017
| $autoPlaylists = static::_upcomingAutoPlaylistShows(); | ||
| foreach ($autoPlaylists as $autoplaylist) { | ||
| // Starting a session | ||
| Zend_Session::start(); |
There was a problem hiding this comment.
I don't think the session is needed at all now that you don't login in a dummy user.
| Application_Model_Preference::setAutoPlaylistPollLock(microtime(true)); | ||
| Zend_Session::stop(); | ||
| Application_Model_Preference::setAutoPlaylistPollLock(microtime(true)); | ||
| Zend_Session::stop(); |
There was a problem hiding this comment.
Same here, no need to stop it if it isn't started in the first place.
There was a problem hiding this comment.
My testing seems to indicate that the session is still necessary. When I comment out the start and stop session I get an authentication error again.
2017-03-22T03:23:05+00:00 INFO (6): localhost Scheduling 1
2017-03-22T03:23:05+00:00 ERR (3): localhost [ErrorController.php:26 - errorAction()] - You must explicitly start the session with Zend_Session::start() when session options are set to strict.
2017-03-22T03:23:05+00:00 ERR (3): localhost [ErrorController.php:27 - errorAction()] - #0 /vagrant/vendor/zendframework/zendframework1/library/Zend/Session/Namespace.php(143): Zend_Session::start(true)
#1 /vagrant/vendor/zendframework/zendframework1/library/Zend/Auth/Storage/Session.php(86): Zend_Session_Namespace->__construct('Zend_Auth')
#2 /vagrant/vendor/zendframework/zendframework1/library/Zend/Auth.php(91): Zend_Auth_Storage_Session->__construct()
#3 /vagrant/airtime_mvc/application/models/User.php(377): Zend_Auth->getStorage()
#4 /vagrant/airtime_mvc/application/models/Scheduler.php(43): Application_Model_User::getCurrentUser()
#5 /vagrant/airtime_mvc/application/models/ShowInstance.php(232): Application_Model_Scheduler->__construct()
#6 /vagrant/airtime_mvc/application/common/AutoPlaylistManager.php(36): Application_Model_ShowInstance->addPlaylistToShow(1, false)
#7 /vagrant/airtime_mvc/application/common/TaskManager.php(248): AutoPlaylistManager::buildAutoPlaylist()
#8 /vagrant/airtime_mvc/application/common/TaskManager.php(61): AutoPlaylistTask->run()
#9 /vagrant/airtime_mvc/application/common/TaskManager.php(104): TaskManager->runTask('AutoPlaylistTas...')
#10 /vagrant/airtime_mvc/application/controllers/plugins/PageLayoutInitPlugin.php(73): TaskManager->runTasks()
#11 /vagrant/vendor/zendframework/zendframework1/library/Zend/Controller/Plugin/Broker.php(260): PageLayoutInitPlugin->routeShutdown(Object(Zend_Controller_Request_Http))
#12 /vagrant/vendor/zendframework/zendframework1/library/Zend/Controller/Front.php(923): Zend_Controller_Plugin_Broker->routeShutdown(Object(Zend_Controller_Request_Http))
#13 /vagrant/vendor/zendframework/zendframework1/library/Zend/Application/Bootstrap/Bootstrap.php(105): Zend_Controller_Front->dispatch()
#14 /vagrant/vendor/zendframework/zendframework1/library/Zend/Application.php(384): Zend_Application_Bootstrap_Bootstrap->run()
#15 /vagrant/airtime_mvc/application/airtime-boot.php(84): Zend_Application->run()
#16 /vagrant/airtime_mvc/public/index.php(68): require_once('/vagrant/airtim...')
hairmare
dismissed
their stale review
session still needed, i'll do some real testing b4 merging
|
It looks like this is the only reason It needs a login. I'll give making that optional a go. |
The user object was triggering the creation of a user context that tried to grab something from the session. The later code never tried to use this due to the checkPerm flag. I'm assuming the user model used to have a sane constructor w/o side effects in the times where this code had it's heyday.
|
I figured out how to get rid of the session. Let me know if it still works for you and I'll merge it. |
|
I tested it and it is working so I think we are ready to commit. Thanks for the help on the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add playlistoshow function had a parameter that wasn't being utilized to allow it to tell the validation to not check the user permissions. The passing of this parameter was added back to the addPlaylistToShow function and this removed the dependence upon initializing a user object with the hardcoded admin password. This fixes #103