Removing TableTools, fixing default stream mount #1140
Conversation
zklosko
changed the title
| @@ -109,7 +109,7 @@ | |||
|
|
|||
| Html5Player.prototype.play = function() { | |||
| console.log('play'); | |||
| playerhtml5_audio.src = this.settings.url+'?'+Math.floor(Math.random() * Math.floor(100000)); | |||
| playerhtml5_audio.src = this.settings.url; //+'?'+Math.floor(Math.random() * Math.floor(100000)); | |||
There was a problem hiding this comment.
I think this was intended as a cache buster but it looks broken anyway.
I roughly tested the micro-site player and that the default stream still works on a fresh install. I wasn't able to test the "Playout History" changes since the branch I'm currently on has way to much unrelated changes to that controller/view. |
|
I figured out what the resizing code is supposed to do. It takes care of the popup from the listen button underneath the on air sign. With this change the window looks a bit to large:
With the code working it should get resized to something like this:
I'm pretty sure that there are better ways to acheive this nowadays, but I haven't touched anything related to popups in modern HTML/JS recently so I'm not sure what the optimal solution would be here. |
|
Interesting... I'm also using Firefox and I haven't had a problem with the resizing. |
zklosko
changed the title
zklosko
force-pushed
the
js-player-fix
branch
from
d3da290
to
4a059b9
Compare
|
I really screwed my branch up. I'm going to start from scratch and make another PR when I'm ready. 😢 |
In this PR, I've removed the TableTools Flash export buttons and functionality, fixed the default logo display, and fixed the default stream mountpoint. At the moment, there is no easy drop-in fix for the Playout History export buttons, but the possibility to create a custom exporter using Vanilla JavaScript and plugin libraries remains. Updating DataTables to 1.10 from 1.9.x completely breaks the interface.
This PR also removes the podcast player from the microsite (#1121 (comment)).Some PHP rewriting was done as well, removing unnecessary echo functions.Issues: #1133 #518
Screenshots