New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default replay gain #1259
Set default replay gain #1259
Conversation
b2f586d
to
e4c48c7
Compare
Slightly different error that exposes a flaw in the patch. It should be in a try catch block, not an if |
You mean replacing this
by this?
I'm trying it now and so far it seems good! :) I found this log that I dont remember seeing before.
Not sure if its related, I share it just in case... |
I confirm Im not getting more Keyerror=replay_gain, but KeyError: 'show_name' yes. |
I'm trying replacing this:
by this:
|
hmm... I think that is indicative of something deeper being a problem here.It looks like media_item isn't being populated correctly overall |
Can you send me a track that causes this error? paddatrapper@debian.org |
sent... |
More info. I had a couple of 2 hours long tracks scheduled side by side. The "now playing" track was playing offline for more that an hour and "suddenly" it went online. I checked the logs (pasted down here) and realized that it was 1 hour left for the next track. Sorry for the length of the logs but dont want to miss smtg.
Next track change
|
e4c48c7
to
a824e48
Compare
a824e48
to
8d259aa
Compare
@matias-tecnosoul this patch now creates what is expected by the playout engine. The issue was the new api way of getting the schedule missed those two fields. There are also now unit tests for testing against what is expected (pulled from the RabbitMQ message that notifies of ad-hoc schedule changes). |
Fixes: #1258
Currently I'm unable to test, so requires feedback from @matias-tecnosoul