Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playout): enhance playout logging #1495

Merged
merged 1 commit into from
Jan 13, 2022

Commits on Jan 13, 2022

  1. feat(playout): enhance playout logging

    Some initial work on modernizing the playout app. This replace any custom logger or
    logging based logger with the logging tools from libretime_shared.logging and loguru.
    
    Removed all the thread/function assigned logger (self.logger = ...), as this makes it
    part of the logic (passing logger though function args) as it should not.
    
    Of a dedicated logger is required for a specific task, it should use
    the create_task_logger function.
    
    - refactor: remove dead code
    - refactor: remove py2 specific fix
    - feat: remove unused test command
    - feat: setup shared cli and logging tools
    - feat: replace logging with loguru
    - feat: setup shared cli and logging tools for notify
    - fix: warn method deos not exist
    - feat: make cli setup the entrypoint
    - fix: install shared modules globally in production
      use extra_requires to load local packages in dev environement
    - feat: configure log path in systemd service
    - feat: default behavior is to log to console only
    - feat: create log dir during install
    - chore: add comment
    - fix: don't create useless dir in install
    - fix: move notify logs to /var/log/libretime dir
    - fix: update setup_logger attrs
    - style: linting
    - fix: replace verbosity flag with log-level flag
    - feat: use shared logging tool in liquidsoap
    - fix: pass logger down to api client
    - feat: allow custom log_filepath in liquidsoap config
    - chore: add pylintrc to playout
    - refactor: fix pylint errors
    - feat: set liquidsoap log filepath in systemd service
    - fix: missing setup entrypoint update
    
    BREAKING CHANGE: for playout and liquidsoap the default log file path changed to None
    and will only log to the console when developing / testing. Unless you are running the
    app as a systemd service (production) the default logs filepaths changed:
    from "/var/log/airtime/pypo/pypo.log" to "/var/log/libretime/playout.log" and
    from "/var/log/airtime/pypo-liquidsoap/ls_script.log" to "/var/log/libretime/liquidsoap.log"
    
    BREAKING CHANGE: for playout-notify the default log file path changed
    from "/var/log/airtime/pypo/notify.log" to "/var/log/libretime/playout-notify.log"
    jooola committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    2728518 View commit details
    Browse the repository at this point in the history