fix: apply replay gain preferences on scheduled files #2945

jooola · 2024-02-08T18:57:47Z

Description

The replay gain preferences are applied in the legacy code, but the playout code was missing this feature. The replay gain was not applied when playout fetched the schedules.

libretime/legacy/application/models/Schedule.php

Lines 881 to 886 in 37d1a76

    
           $replay_gain = is_null($item['replay_gain']) ? '0' : $item['replay_gain']; 
        
           $replay_gain += Application_Model_Preference::getReplayGainModifier(); 
        
           if (!Application_Model_Preference::GetEnableReplayGain()) { 
        
               $replay_gain = 0; 
        
           }

codecov · 2024-02-08T19:20:10Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2b119ad) 70.36% compared to head (3bbb530) 70.42%.
Report is 3 commits behind head on main.

Files	Patch %	Lines
playout/libretime_playout/player/schedule.py	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2945      +/-   ##
==========================================
+ Coverage   70.36%   70.42%   +0.05%     
==========================================
  Files         149      149              
  Lines        4033     4044      +11     
==========================================
+ Hits         2838     2848      +10     
- Misses       1195     1196       +1

Flag	Coverage Δ
api	`93.74% <100.00%> (+0.01%)`	⬆️
playout	`47.60% <90.00%> (+0.19%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🤖 I have created a release *beep* *boop* --- ## [4.1.0](4.0.0...4.1.0) (2024-05-05) ### Features * **api:** implement file deletion ([#2960](#2960)) ([9757b1b](9757b1b)) * build schedule events exclusively in playout ([#2946](#2946)) ([40b4fc7](40b4fc7)) * **legacy:** add aac/opus support to dashboard player ([#2881](#2881)) ([95283ef](95283ef)) * **legacy:** disable public radio page and redirect to login ([#2903](#2903)) ([170d095](170d095)) * **legacy:** trim overbooked shows after autoloading a playlist ([#2897](#2897)) ([a95ce3d](a95ce3d)) * **legacy:** visual cue point editor ([#2947](#2947)) ([da02e74](da02e74)) * start celery worker programmatically ([#2988](#2988)) ([9c548b3](9c548b3)) ### Bug Fixes * **analyzer:** backslash non utf-8 data when probing replaygain ([#2931](#2931)) ([29f73e0](29f73e0)), closes [#2910](#2910) * apply replay gain preferences on scheduled files ([#2945](#2945)) ([35d0dec](35d0dec)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.49.1 ([#2899](#2899)) ([3e05748](3e05748)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.51.1 ([#2963](#2963)) ([22c303c](22c303c)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.53.1 ([#2972](#2972)) ([9192aaa](9192aaa)) * **deps:** update dependency gunicorn to v22 (security) ([#2993](#2993)) ([a2cf769](a2cf769)) * incorrect docker compose version ([#2975](#2975)) ([634e6e2](634e6e2)) * **installer:** setup the worker entrypoint ([#2996](#2996)) ([71b20ae](71b20ae)) * **legacy:** allow deleting file with api token ([#2995](#2995)) ([86da46e](86da46e)) * **legacy:** allow updating track types code ([#2955](#2955)) ([270aa08](270aa08)) * **legacy:** avoid crash when lot of streams in configuration ([#2915](#2915)) ([12dd477](12dd477)) * **legacy:** ensure validation is performed on the track type form ([#2985](#2985)) ([5ad69bf](5ad69bf)) * **legacy:** fix hidden fields in edit file form ([#2932](#2932)) ([f4b260f](f4b260f)) * **legacy:** replay_gain_modifier should be a system preference ([#2943](#2943)) ([37d1a76](37d1a76)) * remove obsolete docker compose version ([#2982](#2982)) ([fb0584b](fb0584b)) * trigger legacy tasks manager every 5m ([#2987](#2987)) ([7040d0e](7040d0e)) * **worker:** ensure celery beat is started ([#3007](#3007)) ([bfde17e](bfde17e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: jo <ljonas@riseup.net>

🤖 I have created a release *beep* *boop* --- ## [4.1.0](libretime/libretime@4.0.0...4.1.0) (2024-05-05) ### Features * **api:** implement file deletion ([#2960](libretime/libretime#2960)) ([9757b1b](libretime/libretime@9757b1b)) * build schedule events exclusively in playout ([#2946](libretime/libretime#2946)) ([40b4fc7](libretime/libretime@40b4fc7)) * **legacy:** add aac/opus support to dashboard player ([#2881](libretime/libretime#2881)) ([95283ef](libretime/libretime@95283ef)) * **legacy:** disable public radio page and redirect to login ([#2903](libretime/libretime#2903)) ([170d095](libretime/libretime@170d095)) * **legacy:** trim overbooked shows after autoloading a playlist ([#2897](libretime/libretime#2897)) ([a95ce3d](libretime/libretime@a95ce3d)) * **legacy:** visual cue point editor ([#2947](libretime/libretime#2947)) ([da02e74](libretime/libretime@da02e74)) * start celery worker programmatically ([#2988](libretime/libretime#2988)) ([9c548b3](libretime/libretime@9c548b3)) ### Bug Fixes * **analyzer:** backslash non utf-8 data when probing replaygain ([#2931](libretime/libretime#2931)) ([29f73e0](libretime/libretime@29f73e0)), closes [#2910](libretime/libretime#2910) * apply replay gain preferences on scheduled files ([#2945](libretime/libretime#2945)) ([35d0dec](libretime/libretime@35d0dec)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.49.1 ([#2899](libretime/libretime#2899)) ([3e05748](libretime/libretime@3e05748)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.51.1 ([#2963](libretime/libretime#2963)) ([22c303c](libretime/libretime@22c303c)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.53.1 ([#2972](libretime/libretime#2972)) ([9192aaa](libretime/libretime@9192aaa)) * **deps:** update dependency gunicorn to v22 (security) ([#2993](libretime/libretime#2993)) ([a2cf769](libretime/libretime@a2cf769)) * incorrect docker compose version ([#2975](libretime/libretime#2975)) ([634e6e2](libretime/libretime@634e6e2)) * **installer:** setup the worker entrypoint ([#2996](libretime/libretime#2996)) ([71b20ae](libretime/libretime@71b20ae)) * **legacy:** allow deleting file with api token ([#2995](libretime/libretime#2995)) ([86da46e](libretime/libretime@86da46e)) * **legacy:** allow updating track types code ([#2955](libretime/libretime#2955)) ([270aa08](libretime/libretime@270aa08)) * **legacy:** avoid crash when lot of streams in configuration ([#2915](libretime/libretime#2915)) ([12dd477](libretime/libretime@12dd477)) * **legacy:** ensure validation is performed on the track type form ([#2985](libretime/libretime#2985)) ([5ad69bf](libretime/libretime@5ad69bf)) * **legacy:** fix hidden fields in edit file form ([#2932](libretime/libretime#2932)) ([f4b260f](libretime/libretime@f4b260f)) * **legacy:** replay_gain_modifier should be a system preference ([#2943](libretime/libretime#2943)) ([37d1a76](libretime/libretime@37d1a76)) * remove obsolete docker compose version ([#2982](libretime/libretime#2982)) ([fb0584b](libretime/libretime@fb0584b)) * trigger legacy tasks manager every 5m ([#2987](libretime/libretime#2987)) ([7040d0e](libretime/libretime@7040d0e)) * **worker:** ensure celery beat is started ([#3007](libretime/libretime#3007)) ([bfde17e](libretime/libretime@bfde17e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: jo <ljonas@riseup.net> libretime/libretime@1a985a4

fix: apply replay gain preferences on scheduled files

d53fd92

jooola force-pushed the fix-replay-gain branch from 4fb684b to d53fd92 Compare February 8, 2024 18:59

test: update playout tests

47ff611

test: write api tests

3bbb530

jooola merged commit 35d0dec into libretime:main Feb 8, 2024
25 checks passed

jooola deleted the fix-replay-gain branch February 8, 2024 19:29

libretime-bot mentioned this pull request Feb 8, 2024

chore(main): release 4.1.0 #2893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: apply replay gain preferences on scheduled files #2945

fix: apply replay gain preferences on scheduled files #2945

jooola commented Feb 8, 2024

codecov bot commented Feb 8, 2024 •

edited

Loading

	$replay_gain = is_null($item['replay_gain']) ? '0' : $item['replay_gain'];
	$replay_gain += Application_Model_Preference::getReplayGainModifier();

	if (!Application_Model_Preference::GetEnableReplayGain()) {
	$replay_gain = 0;
	}

fix: apply replay gain preferences on scheduled files #2945

fix: apply replay gain preferences on scheduled files #2945

Conversation

jooola commented Feb 8, 2024

Description

codecov bot commented Feb 8, 2024 • edited Loading

Codecov Report

codecov bot commented Feb 8, 2024 •

edited

Loading