Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all retro_* callbacks in RetroCore. #20

Merged
2 commits merged into from Dec 14, 2022

Conversation

InquisitiveCoder
Copy link
Contributor

@InquisitiveCoder InquisitiveCoder commented Dec 4, 2022

Exposes all retro_* callbacks in RetroCore. This is necessary to future-proof the crate's API, since environment commands can be specific to certain callbacks. In my opinion it also makes the crate easier to learn since it'll have a close mapping to the C API.

Also makes some slight alterations to the existing RetroCore methods, like removing the redundant size parameter and using associated types instead of just u32 for user-defined enums.

@ghost
Copy link

ghost commented Dec 8, 2022

@InquisitiveCoder let me know when you get this rebased and I'll begin reviewing 👍🏼

@InquisitiveCoder
Copy link
Contributor Author

@InquisitiveCoder let me know when you get this rebased and I'll begin reviewing 👍🏼

Good to go.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure your markdown links work. And, if they are links to code constructs then they are of the form:

[`reference_here`]

Once the comments below are addressed (either implemented, or tell me to kick rocks 😄) I'll merge this. Thanks!

libretro-rs/src/lib.rs Show resolved Hide resolved
libretro-rs/src/lib.rs Outdated Show resolved Hide resolved
libretro-rs/src/memory.rs Outdated Show resolved Hide resolved
libretro-rs/src/av_info.rs Show resolved Hide resolved
@ghost ghost merged commit b7b5266 into libretro-rs:master Dec 14, 2022
@ghost ghost added this to the 0.2.0 milestone Dec 14, 2022
@InquisitiveCoder InquisitiveCoder deleted the expose-all-functions branch April 16, 2023 23:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant