New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose all retro_* callbacks in RetroCore. #20
Conversation
aa48132
to
bcecb4e
Compare
bcecb4e
to
f9101e4
Compare
@InquisitiveCoder let me know when you get this rebased and I'll begin reviewing 👍🏼 |
f9101e4
to
6fc4f96
Compare
6fc4f96
to
9b94edb
Compare
Good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure your markdown links work. And, if they are links to code constructs then they are of the form:
[`reference_here`]
Once the comments below are addressed (either implemented, or tell me to kick rocks 😄) I'll merge this. Thanks!
f49a1dc
to
5d4c513
Compare
Exposes all
retro_*
callbacks inRetroCore
. This is necessary to future-proof the crate's API, since environment commands can be specific to certain callbacks. In my opinion it also makes the crate easier to learn since it'll have a close mapping to the C API.Also makes some slight alterations to the existing
RetroCore
methods, like removing the redundantsize
parameter and using associated types instead of justu32
for user-defined enums.