Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading a .png file automatically opens with the "image display" core even if you have another one compatible with this extension #14148

Open
bslenul opened this issue Jul 5, 2022 · 0 comments

Comments

@bslenul
Copy link
Contributor

bslenul commented Jul 5, 2022

Hey!

Very niche issue but PICO-8 games are in .png format by default, for example if you go to the Celeste page: https://www.lexaloffle.com/bbs/?pid=11722#p and click "Cart" it will open this: https://www.lexaloffle.com/bbs/cposts/1/15133.p8.png , which actually contains the game.

The problem is that if you go to "Load Content" and select the .png, it automatically opens it with the "image display" built-in core, although .png is a valid extension in the Retro8 core: https://github.com/libretro/retro8/blob/afa143ac123034fb7907f05282ac746c214deb1f/src/libretro/libretro.cpp#L191 and in the .info file as well: https://github.com/libretro/libretro-super/blob/6f238f9af976164c108fc73177c72da117bd99bd/dist/info/retro8_libretro.info#L4

It can be very easily worked around by renaming the file to .p8 instead or by loading the core before selecting the .png, so it's not really a huge issue, just annoying. It could become a real problem if someone wants to make a media core or something that can read .png in the future however.

Out of curiosity I also tried adding "mp4" to the supported extensions in the .info file, looks like the same issue exists with FFmpeg core, it just assumes it's the only compatible core. This isn't a valid extension in any other core AFAIK so it's even less of a problem atm, just wanted to point it out :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants