Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Retain state on Android close #14518

Open
whs opened this issue Oct 16, 2022 · 1 comment
Open

Feature Request: Retain state on Android close #14518

whs opened this issue Oct 16, 2022 · 1 comment

Comments

@whs
Copy link

whs commented Oct 16, 2022

First and foremost consider this:

  • Only RetroArch bugs should be filed here. Not core bugs or game bugs
  • This is not a forum or a help section, this is strictly developer oriented

Description

When RetroArch Android is closed by swiping up in Android task switcher, or automatically by the background task killer all progress in RetroArch is lost

Expected behavior

There should be an option (or always on) that flush in memory states to disk on activity onStop()

  • Flush SRAM to disk
  • If auto save state is on, make a save state
  • Flush auto save state to disk

Looking at uwp/uwp_main.cpp App::OnSuspending it seems like similar behavior was implemented for UWP, but not Android

Actual behavior

Everything is lost when the app is killed in background

Steps to reproduce the bug

  1. Play a game in Retroarch
  2. Switch to 5 other apps
  3. Android should've killed Retroarch at this point
  4. Go back to Retroarch. It appears as fresh instance without the game running and all progress are lost

Bisect Results

This is a feature request

Version/Commit

You can find this information under Information/System Information

  • RetroArch: 1.11.1

Environment information

  • OS: Android 12
@gitgudyyao
Copy link

gitgudyyao commented Jan 5, 2023

#14804

fixed this by implementing as mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants