Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Main Menu -> Online Updater -> Update Assets": assets.zip is not extracted #16101

Closed
davidhedlund opened this issue Jan 10, 2024 · 7 comments
Closed

Comments

@davidhedlund
Copy link

davidhedlund commented Jan 10, 2024

First and foremost consider this:

  • Only RetroArch bugs should be filed here. Not core bugs or game bugs
  • This is not a forum or a help section, this is strictly developer oriented

Description

"Main Menu -> Online Updater -> Update Assets" exist in the Appimage, but it failed to extract assets.zip.

Expected behavior

The assets should be applied.

Actual behavior

"Extracting 'assets.zip'"

Steps to reproduce the bug

Extract RetroArch.7z that contains a directory called RetroArch-Linux-x86_64 with the following content:

  • RetroArch-Linux-x86_64.AppImage.home/.config/retroarch/

  • RetroArch-Linux-x86_64.AppImage

  • Main Menu -> Online Updater -> Update Assets

  • "Downloading assets.zip"
    image

  • But assets.zip is not extracted. RetroArch-Linux-x86_64.AppImage.home/.config/retroarch/assets/ is empty.

"Main Menu -> Online Updater -> Update Controller Profiles" (control)

  • Main Menu -> Online Updater -> Update Controller Profiles
  • "Downloading autoconfig.zip"

image

  • "Extracting 'autoconfig.zip'"

image

  • The files have been extracted to .config/retroarch/autoconfig/

Bisect Results

[Try to bisect and tell us when this started happening]

Version/Commit

You can find this information under Information/System Information

  • RetroArch: 1.16.0 Appimage

Environment information

  • OS: GNU/Linux
  • Compiler: [In case you are running local builds]
@davidhedlund davidhedlund changed the title Assets are not applied to the Ozone menu driver "Main Menu -> Online Updater -> Update Assets": Assets are not downloaded Jan 10, 2024
@davidhedlund davidhedlund changed the title "Main Menu -> Online Updater -> Update Assets": Assets are not downloaded "Main Menu -> Online Updater -> Update Assets": Assets are not extracted Jan 10, 2024
@davidhedlund davidhedlund changed the title "Main Menu -> Online Updater -> Update Assets": Assets are not extracted "Main Menu -> Online Updater -> Update Assets": assets.zip is not extracted Jan 10, 2024
@davidhedlund
Copy link
Author

@RobLoach
Copy link
Member

You don't need to use that option since the appimage ships with all the assets already. We should likely disable that menu item, but I'm unsure we're able to do that currently.

@davidhedlund
Copy link
Author

davidhedlund commented Jan 14, 2024

You don't need to use that option since the appimage ships with all the assets already.

Oh, but what if you want to update the assets to the latest version?

We should likely disable that menu item, but I'm unsure we're able to do that currently.

The Appimage also comes with the autoconfig directory, so is it likely that the "Update Controller Profiles" entry also will be disabled?

@RobLoach
Copy link
Member

Oh, but what if you want to update the assets to the latest version?

Then work with the distro maintainer to update them, or change the location of the assets directory in your .cfg.

@davidhedlund
Copy link
Author

Oh, but what if you want to update the assets to the latest version?

Then work with the distro maintainer to update them, or change the location of the assets directory in your .cfg.

Do you want to open a new issue titled something like: [Menu] Remove "Update Assets", and "Update Controller Profiles"?

@RobLoach
Copy link
Member

No, thank you. If you have questions like this, you'll likely get better responses in the Forum or on Discord.

@davidhedlund
Copy link
Author

...or change the location of the assets directory in your .cfg.

That's correct. I had to modify assets_directory = "/usr/share/libretro/assets/" to assets_directory = "~/.config/retroarch/assets/". After that, Main Menu -> Online Updater -> Update Assets extracted the assets.zip file.

I opened this issue for the appimage:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants