New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If run from the command line, pointing to a rom, the libretro-snes9x core is not loading MSU-1 files #4380
Comments
can you try
|
Yeah, that worked. |
I suspected as much... tbh not sure what to do about it. I think when loading from the CLI it doesn't set the path correctly |
Sounds to me like something doing strrchr(thing, '/') and derping out when not finding any slash. |
I can't reproduce this with snes9x-libretro. If you put the rom in its own directory with nothing else does it still happen? Maybe one of the other files in the directory is causing the problem kind of like issues libretro/beetle-psx-libretro#149 or libretro/beetle-saturn-libretro#1. |
Also for reference, fbalpha and tyrquake used to also have this problem. mame2003, mame2010 and mame2014 also have this problem. |
What do you mean? This can only happen with other files in the directory, namely the external pcm music files from the parallel worlds patch (plus the bps patch obviously). If they aren't there, there is no point testing since the rom will always load the normal music. If you meant, if i share directories for roms of the same machine, no i don't. Each game has a directory and it was the case when i tested this. |
It will help in finding out if any of those files is what is causing the path problem. |
Roms load normally either way (prepended ./ or not). The problem is with the MSU-1 files. Without any other file except the rom i'm just testing if the core loads Legend of Zelda A link to the past ofc. I'm in linux if it matters for ifdef code. |
BTW the files needed for the music patch can be got here: Rename all of them to the same name as the rom, except extensions and keep the '-Number' suffixes for pcm too). |
Well, I still can't reproduce this. The patch seems to work, but I'm not sure if the pcm files are?
|
Seems legit. Are you calling it with (this for working audio, for non-working, remove ./ ) |
Yes, I tried both of these with the same result, audio works for both.
However I'm not sure what difference the pcm files are supposed to cause, it sounds the same with and without them. Additionally I am noticing this, even though it is clearly working...
|
That's normal, happens on all patches in retroarch (yes i also find it weird), my softpatching results in the same crc, which proves we're using the same rom and patch. But, if the rom 'sounds the same', even if you load it without the files, it's not actually working. |
Are you using linux? I believe windows has some linux posix compatibility with relative paths that might be confusing the issue (this being fixed on windows but not linux on different codepaths for example). If you actually can see the cd quality music in the intro regardless... well, it's the only way i can see it sanely happening because it sure isn't here. My build is very recent (january 7th). |
Yea, I am using slackware. |
I'm still unsure if this is a core issue or a retroarch issue... |
I'm troubled that no one said it was reproducible myself. I'm not actually inventing it for being annoying. At least i got a workaround out of the issue i guess. |
@i30817 Can you still reproduce this? |
That's a problem. I can no longer find the pcm files on the net from those links or any other link. I think this should probably be closed since i no longer have the means to reproduce it. |
I'll close it then. if anything changes, feel free to reopen. |
I didn't post this on the core repository because if the 'content' is loaded from the gui, it works. Just not from the command line, which indicates a bug before the core loads from commandline. I might be wrong ofc, so tell me to open there if so.
The rom file is softpatched not hardpatched, with the usual parellel worlds bps patch (but it doesn't make a difference, because i tried hardpatching and running from command line and it didn't work), and the audio data is renamed correctly (and plays from the gui).
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: