Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMB Battery and Clock Render Size #4587

Closed
RobLoach opened this issue Feb 7, 2017 · 5 comments
Closed

XMB Battery and Clock Render Size #4587

RobLoach opened this issue Feb 7, 2017 · 5 comments

Comments

@RobLoach
Copy link
Member

RobLoach commented Feb 7, 2017

Description

RetroArch's theme Battery and Clock icons are quite small compared to the image size:

As a result, when using a theme outside of Monochrome that has standard sizes for the icons (like the Material Design theme), the icons end up looking rather large in RA:

batclock

Expected behavior

RetroArch should render the icons smaller on the frontend, rather then expecting the theme to have battery.png and clock.png render small images.

Themes should be able to use a full-sized version of a clock.png.

Steps to reproduce the bug

  1. Install the Material Design theme
  2. Choose "Custom" Menu Font Theme
  3. Enable clock and battery in the menu settings
  4. Close and restart RA
  5. See the icon and battery are larger than the text

Version/Commit

  • RetroArch: 1.4.1

Proposed Solution

  1. Go through all of retroarch-assets themes, resize the clock, battery-full and battery-charging icons so that they match the image sizes
  2. Update RetroArch's XMB rendering of the battery and clock icons that that they're smaller to match the height of the text correctly.
@Alcaro
Copy link
Contributor

Alcaro commented Feb 7, 2017

I really hope that pic does not say 118% battery

@RobLoach
Copy link
Member Author

RobLoach commented Feb 7, 2017

I really hope that pic does not say 118% battery

It really does say 118%.... Just ignore it, I'll update my kernel soon.

@Alcaro
Copy link
Contributor

Alcaro commented Feb 7, 2017

Yeah, your battery is at 214748364800% and everyone who disagrees is a Microsoft lackey.

@RobLoach
Copy link
Member Author

The two PRs are now open over at #4616 and libretro/retroarch-assets#122 . @kivutar mentioned he'd be willing to test.

@RobLoach
Copy link
Member Author

Going to close this, seems there's some mipmapping issues. That's beyond my knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants