Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libretro-db dat_converter has error in msys2 #7586

Closed
markwkidd opened this issue Nov 13, 2018 · 10 comments · Fixed by #7594
Closed

libretro-db dat_converter has error in msys2 #7586

markwkidd opened this issue Nov 13, 2018 · 10 comments · Fixed by #7594

Comments

@markwkidd
Copy link
Contributor

markwkidd commented Nov 13, 2018

UPDATE: I have submitted a PR which fixes the Makefile error but there is still an error on executing dat_converter: ./dat_converter: line 4: ./lua_converter: No such file or directory

I have an msys2 installation set up according to the Compiling Retroarch docs.

  1. git clone http://github.com/libretro/retroarch/ (with the Makefile patch)
  2. cd retroarch && ./configure
  3. cd libretro-db
  4. make
  5. $ ./dat_converter "MAME 2003-Plus.rdb" "MAME 2003-Plus.dat"

Error: ./dat_converter: line 4: ./lua_converter: No such file or directory

@ghost

This comment was marked as spam.

@ofry
Copy link

ofry commented Nov 13, 2018

Maybe it's related:

libretro/libretro-super#905

@ghost

This comment was marked as spam.

@ofry
Copy link

ofry commented Nov 14, 2018

What do you mean? My issue still exist now.

@ghost

This comment was marked as spam.

@markwkidd
Copy link
Contributor Author

I've submitted a PR to apply that diff to the Makefile #7594

@markwkidd markwkidd changed the title libretro-db Makefile has errors in msys2 libretro-db dat_converter has error in msys2 Nov 15, 2018
@markwkidd
Copy link
Contributor Author

I'm able to get farther in the process now but now I'm getting an error that the lua script doesn't exist.

  1. git clone http://github.com/libretro/retroarch/ (with the Makefile patch)
  2. cd retroarch && ./configure
  3. cd libretro-db
  4. make
  5. $ ./dat_converter "MAME 2003-Plus.rdb" "MAME 2003-Plus.dat"

Error: ./dat_converter: line 4: ./lua_converter: No such file or directory

@markwkidd
Copy link
Contributor Author

Minor update: When using the build_databases script from libretro-super to build all of the RDB files, this error does not occur so I'll assume there is something in that script which needs to be added to the instructions for compiling a single RDB.

@ghost
Copy link

ghost commented Nov 15, 2018

libretro-database-build uses c_converter "rdb" "dat", not dat_converter which uses lua (i dont remember using this before to create rdb)

@markwkidd
Copy link
Contributor Author

Thanks @retro-wertz that is quite useful to know.

Once this is sorted out there should definitely be an update to the libretro-db README: https://github.com/libretro/RetroArch/tree/master/libretro-db#dat-file-converter

I'll be glad to write the update -- just wanted to post in the instructions I was following for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants