Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu widgets should be shown above the overlay. #8718

Open
SerjTargarien opened this issue May 7, 2019 · 10 comments
Open

Menu widgets should be shown above the overlay. #8718

SerjTargarien opened this issue May 7, 2019 · 10 comments

Comments

@SerjTargarien
Copy link

Expected behavior

Menu widgets such as achievement notifications or gamepad inputs should be able to be shown over the overlay. Some people use overlays as a way to map virtual buttons on cores when playing on smartphone or tablet devices, but for others an overlay is an anesthetic choice for game bezels or borders.

Actual behavior

As it is now, if you have a bezel activated you can't see the widgets as they are shown under the overlay and only partially visible or not visible at all.

Steps to reproduce the bug

  1. Activate an opaque overlay that covers the borders of the screen.
  2. Take a screen shoot with a hot key or activate an achievent in game.
  3. The widget is not shown or only partially shown because is under the overlay.

Version/Commit

  • RetroArch: 1.7.7

Environment information

  • OS: Windows 10, but the problem is OS independent.
@SerjTargarien SerjTargarien changed the title Menú widgets should be shown above the overlay. Menu widgets should be shown above the overlay. May 7, 2019
@orbea
Copy link
Contributor

orbea commented May 7, 2019

I just want to add I can reproduce this in linux with opengl and vulkan.

@furiadeoso
Copy link

Tagging @natinusala

@natinusala
Copy link
Contributor

I'll have a look at that, I didn't know overlays were video drivers dependent

@natinusala
Copy link
Contributor

This PR fixes it for gl and vulkan: #8732

However, I would suggest not to close this issue until all video drivers are fixed:

  • Metal
  • d3d10
  • d3d11
  • d3d12
  • d3d9
  • gl_core
  • gl1
  • gx2
  • gl
  • vulkan

@andercard0
Copy link

I am facing this issue with Bezels, not sure if this is same as Overlay; When a achievement pops-up (left up corner of screen) with any bezel activated, I barely can see the achievement. I remember when it was on version 1.7.6 on linux and windows, and it was a simple yellow notification, that not happen at all!

If any one knows a workaround, I'd love to try it out!

Thanks!

@Pearate
Copy link

Pearate commented May 10, 2019

When does this fix be available ? and how ?

@Ferk
Copy link

Ferk commented May 16, 2019

It should be tested that the widget doesn't block the input of the touchscreen when used as an overlay for control.

Honestly, I feel like this kind of graphical backdrops should use something else than the overlay that's meant for controls.
Like for example using the new "Onscreen artwork" (from #7419)

@natinusala
Copy link
Contributor

Menu widgets have no inputs whatsoever for now, so overlays are not disturbed.

@SuperMeatBro
Copy link

SuperMeatBro commented May 18, 2019

should it includes the fact that shaders shouldnt affect widget (at least the badge pop-in for cheevos) or it is something completely different than overlay ( i was always seeing shaders as a kind of overlay for me)

@natinusala
Copy link
Contributor

This is a different issue that needs to be tackled too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants