Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional gfx patches not loaded from rom path #8

Open
metchebe opened this issue Mar 14, 2019 · 5 comments
Open

Optional gfx patches not loaded from rom path #8

metchebe opened this issue Mar 14, 2019 · 5 comments

Comments

@metchebe
Copy link

metchebe commented Mar 14, 2019

Cannonball can optionally use two binary files for fixing some graphics in widescreen mode. Conveniently, these files can be downloaded with the Retroarch content downloader which downloads these files and other instructions. These files are packaged in a directory called res/ which is a subdirectory in the directory where the Outrun roms should be placed.

The issue is that the core does not load the files in res/, unless the current working directory where Retroarch is run from is the same directory where res/ is.

The core should search for res/* in the same directory where it is loading roms from.

Noticed on Retroarch Linux from Testing PPA on Kubuntu 18.04.

@metchebe
Copy link
Author

As a followup, here are some images with what the use of these patches improves. It's not a critical issue but it does make for a more complete experience.

Without graphics patch:
epr-10187-190326-230115

With graphics patch:
epr-10187-190326-230147

@vaguerant
Copy link

vaguerant commented Jun 8, 2020

I just encountered the same issue on the Wii and Wii U versions. In those cases, the res directory needs to be on the SD card's root directory to be picked up by the core.

EDIT: I'd imagine this is where the fix is needed:

// Load Modified Widescreen version of tilemap

@crystalct
Copy link

crystalct commented Dec 7, 2020

It depends on if your system works with relative path. On PS3. for example, absolutly no.
I proposed a PR to fix some problems on PS3 and also res folder load

    // --------------------------------------------------------------------------------------------
    // Read LayOut Data File
    // --------------------------------------------------------------------------------------------
#ifdef __CELLOS_LV2__
    extern char rom_path[1024];
    std::string path;
    path = std::string(rom_path);
    path += std::string(filename);
    filename = path.c_str();
#endif

@Tenome
Copy link

Tenome commented Jan 22, 2021

Same issue, I'm not sure if this core is being really updated anymore so I'm just sticking to the desktop version. Here's a compiled release you can grab if you can't compile it yourself.

https://retroreloader.itch.io/outrun86coast

I think it's based on this fork, which is more often updated with features.
https://github.com/J1mbo/cannonball

@Kelvfimer
Copy link

Hello any update on this one? I hope somebody will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants